The Wayback Machine - https://web.archive.org/web/20221216163930/https://github.com/flutter/plugins/pull/6817
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[video_player] Add embedded cc support for video player #6817

Open
wants to merge 29 commits into
base: main
Choose a base branch
from

Conversation

mahdishahbazi3653
Copy link

@mahdishahbazi3653 mahdishahbazi3653 commented Dec 9, 2022

Some videos like HLS includes embedded subtitle in them self. Both mobile native players (Exoplayer and AVPlayer) supports this functionality.
User now can get available subtitle option and set one of it. The video_player will stream subtitle from native to flutter video_player controller caption so we can show in flutter.

Fixed issues:

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the relevant style guides and ran the auto-formatter. (Unlike the flutter/flutter repo, the flutter/plugins repo does use dart format.)
  • I signed the CLA.
  • The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
  • I listed at least one issue that this PR fixes in the description above.
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.
  • I updated CHANGELOG.md to add a description of the change, following repository CHANGELOG style.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@google-cla
Copy link

google-cla bot commented Dec 9, 2022

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@mahdishahbazi3653
Copy link
Author

mahdishahbazi3653 commented Dec 9, 2022

Closing PR Since build fails. Will send separate PR for interface, Android, iOS and video player it self

@stuartmorgan
Copy link
Contributor

stuartmorgan commented Dec 9, 2022

@hellohuanlin
Copy link
Contributor

hellohuanlin commented Dec 12, 2022

Hmmm, this work could be skipped if we migrate to platform view implementation sooner (which supports CC out of the box).

As of now we have no choice but to manually add CC labels. I saw you pushed updates. Let me know if it's ready for review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment