New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[video_player] Add embedded cc support for video player #6817
base: main
Are you sure you want to change the base?
[video_player] Add embedded cc support for video player #6817
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
|
Closing PR Since build fails. Will send separate PR for interface, Android, iOS and video player it self |
|
Please see https://github.com/flutter/flutter/wiki/Contributing-to-Plugins-and-Packages#changing-federated-plugins for our process for multi-package changes. |
|
Hmmm, this work could be skipped if we migrate to platform view implementation sooner (which supports CC out of the box). As of now we have no choice but to manually add CC labels. I saw you pushed updates. Let me know if it's ready for review. |


Some videos like HLS includes embedded subtitle in them self. Both mobile native players (Exoplayer and AVPlayer) supports this functionality.
User now can get available subtitle option and set one of it. The video_player will stream subtitle from native to flutter video_player controller caption so we can show in flutter.
Fixed issues:
Pre-launch Checklist
dart format.)[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style.///).If you need help, consider asking for advice on the #hackers-new channel on Discord.