There are no hard and fast rules—Only tradeoffs.
Block or Report
Block or report inancgumus
Report abuse
Contact GitHub support about this user’s behavior. Learn more about reporting abuse.
Report abusePinned
1,118 contributions in the last year
Less
More
Activity overview
Contribution activity
November 2022
Created 26 commits in 2 repositories
Created a pull request in grafana/xk6-browser that received 1 comment
Refactor parseDevToolsURL (#617)
Separates the parsing from concurrently waiting. Advantages: Separation of concerns. Parsing logic or error handling can be changed (maintained) a…
+260
−44
•
1
comment
Opened 3 other pull requests in 1 repository
grafana/xk6-browser
3
merged
Reviewed 18 pull requests in 2 repositories
grafana/xk6-browser
17 pull requests
- Refactor lifecycle tests and add any missing tests
- Add/641 naked browser launch opts
- Refactor the frame's lifecycle event handling code
- Update release version in main
- Fix deadlock with executionContextMu
- Release notes v0.6.0
- Force browser opts in cloud
- Fix a race condition with logCache.entries
- Update k6 dependency to latest stable v0.41.0
- Add mutex to prevent data race on pendingDoc and use mutex when reading frame.inflightRequests
- Fix the ip address in browser_args
- chore: remove static chromium version
- Fix waituntil for page.reload
- Fix WaitForLoadState and add tests
- Wait for browser process to exit before returning first error from stderr
- Browser should not override defaults with null values
- Log when a launch option is set to null






