The Wayback Machine - https://web.archive.org/web/20221122214922/https://github.com/getsentry/sentry/
Skip to content

getsentry/sentry

master
Switch branches/tags

Name already in use

A tag already exists with the provided branch name. Many Git commands accept both tag and branch names, so creating this branch may cause unexpected behavior. Are you sure you want to create this branch?
Code

Latest commit

## Summary

This PR contains some minor UI enhancements to improve the `flamechart`
search ux.

~~- debounces the search input as it would previously block the event
loop causing the UI to hang~~
- adds search result cycling  similar to `cmd+f` in chrome
~~- highlights searchResults in minimap~~

Closes: getsentry/team-profiling#104

Note: after some exploration, `fuse.search` seems to be the bottleneck
causing jank. its problematic with an increasingly large query where
fuse needs to take more of a fuzzy approach. attempts to make the fuzzy
matching stricter doesn't improve performance and also changes the
behaviour of highlihting substrings.

tldr; either we always debounce, debounce under certain conditions (this
can get a bit out of control), or we explore something other than fuse.

Before w/ jank:


https://user-images.githubusercontent.com/7349258/202803171-a2edf865-1f70-4b09-990c-c672d93f4eb2.mov

After - debounced w/o jank + search result cycling:


https://user-images.githubusercontent.com/7349258/202803264-2d053a9e-4a84-40a2-882e-a8411068a24f.mov
9bfb65d

Files

Permalink
Failed to load latest commit information.
Type
Name
Latest commit message
Commit time
.tx
Mar 23, 2013
Nov 15, 2022
Nov 15, 2022

Sentry

Users and logs provide clues. Sentry provides answers.

What's Sentry?

Sentry is a developer-first error tracking and performance monitoring platform that helps developers see what actually matters, solve quicker, and learn continuously about their applications.

Official Sentry SDKs

Resources