The Wayback Machine - https://web.archive.org/web/20220612124052/https://github.com/markedjs/marked/pull/2277
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: avoid linefeed errors running tests on windows #2277

Merged
merged 1 commit into from Nov 11, 2021
Merged

fix: avoid linefeed errors running tests on windows #2277

merged 1 commit into from Nov 11, 2021

Conversation

webstech
Copy link
Contributor

@webstech webstech commented Nov 10, 2021

Some tests fail on windows due to \r\n vs \n:
code_compensation_indent
code_consistent_newline
whiltespace_lines (sic)

Updated .gitattributes to preserve the eol value.

Files in test/specs/new were refreshed to have new attributes applied prior to testing. No failures were reported.

Marked version:
n/a

Contributor

  • Test(s) exist to ensure functionality and minimize regression (if no tests added, list tests covering this PR); or,
  • [] no tests required for this PR.
  • If submitting new feature, it has been documented in the appropriate places.

Committer

In most cases, this should be a different person than the contributor.

Updated title to clarify this only applies to running the test suite and not general usage.

Some tests fail on windows due to `\r\n` vs `\n`:
code_compensation_indent
code_consistent_newline
whiltespace_lines (sic)

Updated .gitattributes to preserve the `eol` value.

Signed-off-by: Chris. Webster <chris@webstech.net>
@vercel
Copy link

@vercel vercel bot commented Nov 10, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/markedjs/markedjs/4x3JJMKMxknwVECqoyjnC9DxHbZ5
Preview: https://markedjs-git-fork-webstech-cw-eol-markedjs.vercel.app

@webstech webstech changed the title fix: avoid linefeed errors running on windows fix: avoid linefeed errors running tests on windows Nov 10, 2021
@UziTech UziTech merged commit a34e86e into markedjs:master Nov 11, 2021
2 checks passed
@UziTech
Copy link
Member

@UziTech UziTech commented Nov 11, 2021

Thanks 💯

Copy link

@Uselessman79 Uselessman79 left a comment

Suuure

@github-actions
Copy link

@github-actions github-actions bot commented Nov 12, 2021

🎉 This PR is included in version 4.0.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3 participants