Update count_number_of_one_bits.py

[JatinR05]

removed the modulo operator as it is very time consuming in comparison to the and operator

Describe your change:

• Add an algorithm?
• Fix a bug or typo in an existing algorithm?
• Documentation change?

Checklist:

• I have read CONTRIBUTING.md.
• This pull request is all my own work -- I have not plagiarized.
• I know that pull requests will not be merged if they fail the automated tests.
• This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
• All new Python files are placed inside an existing directory.
• All filenames are in all lowercase characters with no spaces or dashes.
• All functions and variable names follow Python naming conventions.
• All function parameters and return values are annotated with Python type hints.
• All functions have doctests that pass the automated testing.
• All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
• If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

[cclauss]

Please add a timeit (or similar) benchmark to prove that the proposed code is faster than the original code.
There are lots of examples in this repo. https://github.com/TheAlgorithms/Python/search?q=timeit

[JatinR05]

I have updated my code. It would be great if you could have a look into it.

[JatinR05]

I have updated the code as suggested.

[cclauss]

Please run this on your own machine. The doctest fails.

[JatinR05]

I am extremely sorry for the silly mistakes. Please could you check it now

[cclauss]

Would it be more self-documenting to change the variable number to bit_length throughout the script?

Let's make benchmark() more readable with something like this.

def benchmark() -> None:
    """
    Benchmark code for comparing 2 functions, with different length int values.
    """
    def do_benchmark(number: int) -> None:
        setup = "import __main__ as z"
        print(f"Benchmark when {number = }:")
        print(f"{get_set_bits_count_using_modulo_operator(number) = }")
        timing = timeit("z.get_set_bits_count_using_modulo_operator(25)", setup=setup)
        print(f"timeit() runs in {timing} seconds")
        print(f"{get_set_bits_count_using_brian_kernighans_algorithm(number) = }")
        timing = timeit(
            "z.get_set_bits_count_using_brian_kernighans_algorithm(25)",
            setup=setup,
        )
        print(f"timeit() runs in {timing} seconds")

    for number in (25, 37, 58, 0):
        do_benchmark(number)
        print()

[JatinR05]

I guess the variable name "number" is more appropriate as it's representing the number which the user will be providing as the input and not the bit_length.
Regarding the benchmark updates, it's really a great idea. I'll surely update it.

[cclauss]

Awesome contribution. Thanks for doing this!!

[JatinR05]

Hi could you please add a label of hacktoberfest-accepted.

[JatinR05]

Thank you.