Fixed Windows ISO downloads #42
Closed
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Just specifying: while the referer contains 'windows11', it does indeed work for Windows 10 and 8.1 as well. |
namehorn
suggested changes
Aug 13, 2022
| @@ -801,7 +801,7 @@ function Get-Windows-Download-Links([int]$SelectedVersion, [int]$SelectedRelease | |||
|
|
|||
| try { | |||
| $Is64 = [Environment]::Is64BitOperatingSystem | |||
| $r = Invoke-WebRequest -Method Post -UseBasicParsing -UserAgent $UserAgent -WebSession $Session $url | |||
| $r = Invoke-WebRequest -Method Post -Headers @{'Referer' = 'https://www.microsoft.com/software-download/windows11'} -UseBasicParsing -UserAgent $UserAgent -WebSession $Session $url | |||
There was a problem hiding this comment.
Consider using the windows version variable: $WindowsVersions[$SelectedVersion][0][1]
There was a problem hiding this comment.
I don't think we want to do that for now, because https://www.microsoft.com/software-download/windows8.1 is not a valid page, and that's the URL we'd get for 8.1...
As long as Microsoft's server don't seem to care about the version, using window11 should be good enough.
There was a problem hiding this comment.
Agree with that KISS approach even though this edge case with 8.1 / windows8ISO would be easily handlebar.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Fix for issue #41, the request now requires the Referer to be set properly.