The Wayback Machine - https://web.archive.org/web/20220730165433/https://github.com/angular/angular/issues/46873
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ngUpgrade documentation appears to self-contradict #46873

Open
jmwolfe opened this issue Jul 18, 2022 · 1 comment
Open

ngUpgrade documentation appears to self-contradict #46873

jmwolfe opened this issue Jul 18, 2022 · 1 comment
Labels
comp: docs good first issue P5
Milestone

Comments

@jmwolfe
Copy link

@jmwolfe jmwolfe commented Jul 18, 2022

Description

First this section says:

So normally a hybrid application begins life as an AngularJS application, and it is AngularJS that processes the root template, for example, the index.html. Angular then steps into the picture when an Angular component is used somewhere in an AngularJS template. The template of that component will then be managed by Angular, and it may contain any number of Angular components and directives.

A little later on it says:

To bootstrap a hybrid application, you must bootstrap each of the Angular and AngularJS parts of the application. You must bootstrap the Angular bits first and then ask the UpgradeModule to bootstrap the AngularJS bits next.

it's very counter-intuitive that if AngularJS reads the initial index.html and starts the application, that you would be bootstrapping Angular first. By "starts life" do you mean it was written years ago in AngularJS?

What is the affected URL?

https://angular.io/guide/upgrade#upgrading-with-ngupgrade

Please provide the steps to reproduce the issue

It's documentation, n/a

Please provide the expected behavior vs the actual behavior you encountered

I would expect all the documentation to not contradict itself

Please provide a screenshot if possible

No response

Please provide the exception or error you saw

No response

Is this a browser-specific issue? If so, please specify the device, browser, and version.

No
@jmwolfe jmwolfe changed the title ngUupgrade documentation appears to self-contradict ngUpgrade documentation appears to self-contradict Jul 18, 2022
@jessicajaniuk jessicajaniuk added the comp: docs label Jul 18, 2022
@ngbot ngbot bot added this to the needsTriage milestone Jul 18, 2022
@bob-watson bob-watson added state: needs eng input P2 labels Jul 20, 2022
@ngbot ngbot bot removed this from the needsTriage milestone Jul 20, 2022
@ngbot ngbot bot added this to the Backlog milestone Jul 20, 2022
@ngbot ngbot bot removed this from the needsTriage milestone Jul 20, 2022
@ngbot ngbot bot added this to the Backlog milestone Jul 20, 2022
@atscott
Copy link
Contributor

@atscott atscott commented Jul 20, 2022

Yes, "starts life" refers to an application that was written in AngularJS and is being upgraded to Angular gradually.

@atscott atscott added P5 and removed P2 state: needs eng input labels Jul 20, 2022
@bob-watson bob-watson added the good first issue label Jul 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comp: docs good first issue P5
4 participants