System information

Geth
Version: 1.10.13-stable
Git Commit: 7a0c19f813e285516f4b525305fd73b625d2dec8
Architecture: amd64
Go Version: go1.17.3
Operating System: linux
GOPATH=
GOROOT=go

Expected behaviour

Close files that aren't in use / have a settable limit

Actual behaviour

Every database file it opens stays open for the duration of the sync

Steps to re

Whiskers' regex looks for <..> as opposed to tokenizing the input, so it is not able to detect truncated/mistyped input.

For example it can't detect that <!b is not terminated in<?b> X <!b Y </b>.

With some heuristics it could be improved: match for <?, <! and </ and only allow identifiers which are terminated with >, otherwise it is invalid.

_Originally posted by @axic in h

• I've opened a support ticket before filing this issue.

Issue

Tests are not isolated from each other. I reproduced it using the metacoin box tutorial, adding a new test at the end that checks again the balance. As per the "clean-room" the first account should have all 10000 tokens. It's not.

A parametrized option to set the blocksize would be useful to experiment with. As quorum is used in a private setting I think this option should be available

Describe the enhancement

Every "section" of the video is separated by a clip of what's in ./img/hh-fcc-background.png. We currently have the title text of each section in this repo, but we don't have the timestamp in here!

Component

Forge

Describe the feature you would like

forge snapshot can be a bit pedantic:

https://twitter.com/devtooligan/status/1551965598149513216

there was some discussion re merging --gas-report and snapshot https://github.com/fou

I've seen this mistake more than a couple of times already, so I think it's worth doing this little extra check.