The Wayback Machine - https://web.archive.org/web/20220803233239/https://github.com/facebook/react/pull/24992
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up unused Deletion flag #24992

Merged
merged 1 commit into from Aug 3, 2022

Conversation

acdlite
Copy link
Member

@acdlite acdlite commented Jul 26, 2022

This was replaced by the ChildDeletion flag when we refactored the commit phase.

This was replaced by the ChildDeletion flag when we refactored the 
commit phase.
@facebook-github-bot facebook-github-bot added CLA Signed React Core Team labels Jul 26, 2022
@sizebot
Copy link

@sizebot sizebot commented Jul 26, 2022

Comparing: 2c7dea7...81eae75

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.min.js = 132.92 kB 132.86 kB = 42.68 kB 42.67 kB
oss-experimental/react-dom/cjs/react-dom.production.min.js = 138.15 kB 138.09 kB = 44.19 kB 44.18 kB
facebook-www/ReactDOM-prod.classic.js = 469.02 kB 468.96 kB = 84.22 kB 84.20 kB
facebook-www/ReactDOM-prod.modern.js = 454.26 kB 454.20 kB = 81.98 kB 81.97 kB
facebook-www/ReactDOMForked-prod.classic.js = 469.02 kB 468.96 kB = 84.22 kB 84.20 kB

Significant size changes

Includes any change greater than 0.2%:

(No significant changes)

Generated by 🚫 dangerJS against 81eae75

@acdlite acdlite merged commit b4204ed into facebook:main Aug 3, 2022
36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed React Core Team
4 participants