System information

Geth
Version: 1.10.13-stable
Git Commit: 7a0c19f813e285516f4b525305fd73b625d2dec8
Architecture: amd64
Go Version: go1.17.3
Operating System: linux
GOPATH=
GOROOT=go

Expected behaviour

Close files that aren't in use / have a settable limit

Actual behaviour

Every database file it opens stays open for the duration of the sync

Steps to re

Whiskers' regex looks for <..> as opposed to tokenizing the input, so it is not able to detect truncated/mistyped input.

For example it can't detect that <!b is not terminated in<?b> X <!b Y </b>.

With some heuristics it could be improved: match for <?, <! and </ and only allow identifiers which are terminated with >, otherwise it is invalid.

_Originally posted by @axic in h

The backup storage format being defined very simple and dumb, which is expected, there are a few bad cases people need to be careful with.

1. on the backup side, two backup coordinators can run at the same time and write to the storage at the same time, creating duplicate, or even worse, conflicting (if the two coordinators read different chains) backups.
2. on the "read" side, backup CLI tool

When deploying fabric in enterprise's intranet (without the ability to access internet), users maybe upload chaincode builder images and chaincode runtime images to a private docker registry which requires authentication when pulling images.
I think fabric can support this scenario by adding configuration in chaincode section of core.yaml, such as:

chaincode:
    registry:
        

• I've opened a support ticket before filing this issue.

Issue

Tests are not isolated from each other. I reproduced it using the metacoin box tutorial, adding a new test at the end that checks again the balance. As per the "clean-room" the first account should have all 10000 tokens. It's not.

Problem

Loss and latency metrics might be interesting from the gossip ping-pong protocol.

Proposed Solution

Capture and report them.

Creating a new issue based on lbryio/lbry-sdk#877

• Update ensure_directory_exists() to check that the directory is writable by the current process.
• If it's not, return a useful error
• Add tests to cover the case when
  • download directory does not exist
  • download dir exists but is not writable
  • dir exists an

The htlcswitch test function initSwitchWithDB may create its own database if nil is passed in. Several tests that pass in nil never remove the temporary directory. I don't think any of the tests call db.Close so the test process will still have the file handle. This leads to too many open files... on my machine. The fix here is to remove the temp directory and call Close on the databas

In working on informalsystems/tendermint-rs#1144, I see that the statesync.fetchers configuration option is serialized as a string. Does it need to be a string? It seems like it should be an integer value.

The custom parseUrl() implementation contains a potential edge case issue regarding the parsing of ports.

Consider the following group in the regular expression that determines basic acceptance of the URL: StringUtilities.cpp#L61-L62

 // optional port

A parametrized option to set the blocksize would be useful to experiment with. As quorum is used in a private setting I think this option should be available