fkling
Follow
Pinned
559 contributions in the last year
Activity overview
Contributed to
sourcegraph/sourcegraph,
fkling/astexplorer,
sourcegraph/handbook
and 2 other
repositories
Contribution activity
July 2022
Created 23 commits in 2 repositories
Created a pull request in sourcegraph/sourcegraph that received 3 comments
search: Remove focus from search query input when pressing Escape (CodeMirror)
Addresses #29937 for CodeMirror sg-cm-escape.mp4 Test plan Focus main query input, press escape. Focus should be removed. App preview: Web …
+14
−0
•
3
comments
Opened 21 other pull requests in 1 repository
sourcegraph/sourcegraph
5
open
16
merged
- search: Use @codemirror/lint and add support for actions
- search: Update filter diagnostic to ignore non-existing values
- search: Add placeholder to fallback query input
- codemirror: Upgrade to version 6
- Subscribe myself to search code file changes
- search: Hide/cancel suggestions after query is submitted (CodeMirror)
- search: Update supported languages in lang: filter suggestions
- Use global search query syntax highlighting classes for query input
- search: Show token information for operators (CodeMirror)
- search: Include ranges in query parse nodes and fix parenthesis
- codemirror: Mark label match in dynamic filter suggestions
- codemirror: Improve suggestions handling
- codemirror: Fix suggestions snippet behavior
- Fix flaky repository tags page integration test
- (partial) Fix pinned hovercard rendering with using back/forward buttons
- Avoid duplicate history entries for the same line position
- Simplify blob view line highlighting logic
- Fix duplicate history entry on selecting lines
- Fix scrolling first selected line into view
- codemirror: Show a loading indicator for search query suggestions
- notebooks: Fix markdown block height
Reviewed 14 pull requests in 1 repository
sourcegraph/sourcegraph
14 pull requests
- Use global search query syntax highlighting classes for query input
- search: Show token information for operators (CodeMirror)
- search: Include ranges in query parse nodes and fix parenthesis
- search frontend: highlight queries accurately everywhere
- codemirror: Mark label match in dynamic filter suggestions
-
Accessibility: Fix
ButtonLinkblocking focus - [a11y] notepad: make into a landmark
- Webapp: Fix type re-exports in code insights components
- Avoid duplicate history entries for the same line position
- search: remove onboarding tour
- Simplify blob view line highlighting logic
- codemirror: Show a loading indicator for search query suggestions
- codemirror: Migrate SiteAdminPingsPage to use CodeMirror
- notebooks: Migrate query inputs from Monaco to CodeMirror
Created an issue in sourcegraph/sourcegraph that received 1 comment
search: TypeScript search query scanner produces empty pattern tokens
This happens when the query contains two consecutive closing grouping parenthesis, e.g. (a or (b and c)). The last three tokens will be
{ "type": …
1
comment