The Wayback Machine - https://web.archive.org/web/20220709012702/https://github.com/files-community/Files/issues/9440
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pressing escape while searching should cancel the search #9440

Open
Tamnac opened this issue Jun 20, 2022 · 7 comments
Open

Pressing escape while searching should cancel the search #9440

Tamnac opened this issue Jun 20, 2022 · 7 comments
Labels
feature request good first issue triage approved

Comments

@Tamnac
Copy link

@Tamnac Tamnac commented Jun 20, 2022

What's the Problem?

Currently if you are in the middle of a search and press escape, the app treats it like enter and continues the search. This goes against the escape button's supposed behavior.

Solution/Idea

Pressing escape should cancel the search.

Alternatives

Using the mouse to cancel the search.

Priorities

Capability Priority
Pressing esc cancels search Must

Files Version

Version: 2.3.0.0

Windows Version

10.0.19044.1766

Comments

No response

@yaichenbaum yaichenbaum added triage approved good first issue labels Jun 21, 2022
@yaichenbaum yaichenbaum added this to Backlog in Files via automation Jun 21, 2022
@squirrelnest1986
Copy link

@squirrelnest1986 squirrelnest1986 commented Jun 22, 2022

Kinda just going with the flow

@Shenbhagam
Copy link

@Shenbhagam Shenbhagam commented Jun 23, 2022

It definitely makes the app close and there might me a chance of missing updates or code that you had made before exit.

@Saso2022
Copy link

@Saso2022 Saso2022 commented Jul 1, 2022

الخروج

@Tamnac
Copy link
Author

@Tamnac Tamnac commented Jul 1, 2022

Something strange, I got a comment from @Sugarlust asking for details but I can't see it here, and I'm not sure what @squirrelnest1986 , @Shenbhagam and @Saso2022 are on about.

@Sugarlust
Copy link

@Sugarlust Sugarlust commented Jul 1, 2022

@Tamnac i did make the comment and I myself can't see it anymore can you help and lemme know where I should start looking for the issue.

@Tamnac
Copy link
Author

@Tamnac Tamnac commented Jul 1, 2022

I just reported the issue and don't have any experience with the project itself so I can't help you much technically. The issue is that when a user is searching and presses esc (escape) it should cancel the the search, but it doesn't, instead it seems to treat it like enter.

I'm guessing you would need to set up some sort of event listener for esc and when it comes call some function to cancel the search. For anything more concrete or where to look you'll have to wait for someone who has worked on this project.

@13601981
Copy link

@13601981 13601981 commented Jul 5, 2022

باید جستجو را لغو کند

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request good first issue triage approved
7 participants