The Wayback Machine - https://web.archive.org/web/20220706143138/https://github.com/TheAlgorithms/Python/pull/6194
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add hamming distance #6194

Merged
merged 4 commits into from Jul 6, 2022
Merged

Conversation

saybarsnazlica
Copy link
Contributor

@saybarsnazlica saybarsnazlica commented Jun 13, 2022

Describe your change:

I added the algorithm to calculate the hamming distance between two strings.

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.
@algorithms-keeper algorithms-keeper bot added require tests require type hints awaiting reviews labels Jun 13, 2022
Copy link

@algorithms-keeper algorithms-keeper bot left a comment

Click here to look at the relevant links ⬇️

🔗 Relevant Links

Repository:

Python:

Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.

algorithms-keeper commands and options

algorithms-keeper actions can be triggered by commenting on this PR:

  • @algorithms-keeper review to trigger the checks for only added pull request files
  • @algorithms-keeper review-all to trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.

NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.

strings/hamming_distance.py Outdated Show resolved Hide resolved
@algorithms-keeper algorithms-keeper bot removed require tests require type hints labels Jun 13, 2022
@saybarsnazlica
Copy link
Contributor Author

@saybarsnazlica saybarsnazlica commented Jun 22, 2022

@lachlantownshend Could you please review this pull request?

poyea
poyea approved these changes Jul 3, 2022
Copy link
Member

@poyea poyea left a comment

Thank you for your pull request!🤩

@algorithms-keeper algorithms-keeper bot removed the awaiting reviews label Jul 3, 2022
strings/hamming_distance.py Outdated Show resolved Hide resolved
@poyea poyea added the awaiting merge label Jul 3, 2022
@algorithms-keeper algorithms-keeper bot added awaiting reviews and removed awaiting merge labels Jul 4, 2022
@saybarsnazlica saybarsnazlica requested a review from poyea Jul 4, 2022
@algorithms-keeper algorithms-keeper bot added the tests are failing label Jul 6, 2022
@poyea poyea merged commit 89fc7bf into TheAlgorithms:master Jul 6, 2022
1 of 2 checks passed
@algorithms-keeper algorithms-keeper bot removed the awaiting reviews label Jul 6, 2022
@saybarsnazlica saybarsnazlica deleted the hamming-distance branch Jul 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tests are failing
3 participants