The Wayback Machine - https://web.archive.org/web/20220609084051/https://github.com/PaperMC/Paper/issues/5886
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hitting a TNT Minecart does not trigger EntityKnockbackByEntityEvent #5886

Open
3 tasks done
cksmith51 opened this issue Jun 19, 2021 · 2 comments
Open
3 tasks done

Hitting a TNT Minecart does not trigger EntityKnockbackByEntityEvent #5886

cksmith51 opened this issue Jun 19, 2021 · 2 comments
Labels
good first issue needs testing type: bug version: 1.17

Comments

@cksmith51
Copy link

@cksmith51 cksmith51 commented Jun 19, 2021

Expected behavior

I melee a TNT Minecart with a knockback 2 sword and expect my message listening on EntityKnockbackByEntityEvent to print out the EntityTypes of both #.getEntityType() and #.getHitBy().getEntityType(). (The event should trigger properly.)

Observed/Actual behavior

No message is printed out because hitting a TNT Minecart (or regular minecart) does not trigger EntityKnockbackByEntityEvent. Also tested with a punch bow on mobs (does trigger) but does not trigger on the Minecart.

Steps/models to reproduce

Listen on EntityKnockbackByEntityEvent and print a message any time event is fired with the entitytype of the hit entity. Hit a TNT Minecart or regular minecart.

Plugin list

ApolloUHC (my custom plugin)

Paper version

git-Paper-"3d43c5e"

Agreements

  • I am running the latest version of Paper available from https://papermc.io/downloads.
  • I have searched for and ensured there isn't already an open issue regarding this.
  • My version of Minecraft is supported by Paper.

Other

Using a knockback sword better shows the minecart getting knocked back. Spam click the minecart so that it does not break immediately.

@Chew Chew added type: bug version: 1.17 and removed status: needs triage labels Jun 19, 2021
@limbo-app limbo-app removed type: bug version: 1.17 labels Jun 19, 2021
@cksmith51
Copy link
Author

@cksmith51 cksmith51 commented Jun 21, 2021

@Chew for some reason limbo removed the tags you added, any reason why it did that?

@Proximyst Proximyst added type: bug version: 1.17 good first issue needs testing labels Jun 21, 2021
@cksmith51
Copy link
Author

@cksmith51 cksmith51 commented Jun 21, 2021

Upon further investigation, the event only triggers for LivingEntity. I feel this should be updated to include all entities since all types of Minecart, as well as Fireballs, can take knockback from other types of entities (In these cases, players and arrows)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue needs testing type: bug version: 1.17
4 participants