The Wayback Machine - https://web.archive.org/web/20220810045745/https://github.com/microsoft/react-native-windows/issues/7251
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OfficePreDisabledWarnings applies to all of RNW, not just Office #7251

Open
asklar opened this issue Mar 3, 2021 · 1 comment
Open

OfficePreDisabledWarnings applies to all of RNW, not just Office #7251

asklar opened this issue Mar 3, 2021 · 1 comment

Comments

@asklar
Copy link
Member

@asklar asklar commented Mar 3, 2021

PropertySheets\Warnings.props:

  <PropertyGroup>
    <!-- Office pre-disabled warnings -->
    <!--
        C4201 - nonstandard extension used : nameless struct/union
        C4505 - 'function' : unreferenced local function has been removed
        C4456 - declaration of 'identifier' hides previous local declaration
        C4458 - declaration of 'identifier' hides class member
        C4702 - unreachable code
      -->
    <OfficePreDisabledWarnings>4201;4505;4456;4458;4702</OfficePreDisabledWarnings>

<!-- more stuff ... -->

  <ItemDefinitionGroup>
    <ClCompile>
      <!-- /permissive- by default to enforce standards conformance, unless ENABLEPermissive has been set -->
      <AdditionalOptions Condition="'$(ENABLEPermissive)' == ''">/permissive- %(AdditionalOptions)</AdditionalOptions>
      <DisableSpecificWarnings>$(OfficePreDisabledWarnings);$(ExtraWarningsToDisable);$(DisableSpecificWarnings)</DisableSpecificWarnings>
@asklar asklar added the bug label Mar 3, 2021
@msftbot msftbot bot added the Needs: Triage 🔍 label Mar 3, 2021
@chrisglein
Copy link
Member

@chrisglein chrisglein commented Mar 4, 2021

Do we remove these warning disables? (fix the code)
Or are these disables more general? (as they are being applied for everyone and have for many versions)

Preference to go remove these and fix up the code.

Next step here would be to start removing these warning disables one by one and cataloging the code that breaks. Either fix those or dump them in this issue so we can collectively start burning them down.

@chrisglein chrisglein added Code Cleanup enhancement and removed Needs: Triage 🔍 bug labels Mar 4, 2021
@chrisglein chrisglein added this to the Backlog milestone Mar 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment