Add slash to links to avoid unnecessary redirects #79
Conversation
Links to folder content generated by Publish don't seem to end with a trailing "/", which means there will be an additional HTTP redirect request to the resource with the path appended. You can see an example of this by going to https://swiftbysundell.com/articles/the-decade-of-swift in Safari: you will see it redirected to https://swiftbysundell.com/articles/the-decade-of-swift/, which is an unnecessary redirect. This is more obvious when using curl: ```shell marc@bix ~ % curl -v https://swiftbysundell.com/articles/the-decade-of-swift … blah blah blah … < location: https://swiftbysundell.com/articles/the-decade-of-swift/ < <!DOCTYPE HTML PUBLIC "-//IETF//DTD HTML 2.0//EN"> <html><head> <title>301 Moved Permanently</title> </head><body> <h1>Moved Permanently</h1> <p>The document has moved <a href="https://swiftbysundell.com/articles/the-decade-of-swift/">here</a>.</p> </body></html> * Connection #0 to host swiftbysundell.com left intact * Closing connection 0 ``` TBH, I have no idea of this patch is the correct solution to this inefficiency, but in the absence of an issue tracker, there's no other forum for describing the issue.
|
Good catch, this seems like a bug to me. |
|
Definitely! Not having trailing |
|
I am converting my sites over to Publish. For now, I am using Publish as-is and overriding behaviour using added code and steps as intended by the Publish framework. I am going to use JSON-LD metadata on the pages and need URLs that are the true page reference. Publish relies on redirects to slash terminated URL by the server. I used the I then added; a clone of extension Path {
func slashTerminated() -> Path {
guard !string.isEmpty else {
return ""
}
let separator = (string.last == "/" ? "" : "/")
return "\(string)\(separator)"
}
}This is not necessarily efficient but should still work if Publish ever changes to add the slash. I then do my own html generation. Fix the head canonical: return .head(
.encoding(.utf8),
.viewport(.accordingToDevice),
.link(.rel(.canonical),
.href(context.site.url(for: thisPath.slashTerminated()))),Watch for the 301 redirects and change other fileprivate static func itemList<T: Website>(for items: [Item<T>], on site: T) -> Node {
return .ul(
.class("item-list"),
.forEach(items) { item in
.li(
.article(
.h2(
.a(
.href(item.path.slashTerminated()),
.text(item.title)
)),
.tagList(for: item, on: site),
.p(.text(item.description))
))
}
)
}I have no problem with also doing the 301 redirects on the server for human users. My decision was swayed by JSON-LD and the Markdown relative links that truly need the trailing slash to be relative from. |
Links to folder content generated by Publish don't seem to end with a trailing "/", which means there will be an additional HTTP redirect request to the resource with the path appended. You can see an example of this by going to https://swiftbysundell.com/articles/the-decade-of-swift in Safari: you will see it redirected to https://swiftbysundell.com/articles/the-decade-of-swift/, which is an unnecessary redirect.
This is more obvious when using curl:
TBH, I have no idea of this patch is the correct solution to this inefficiency, but in the absence of an issue tracker, there's no other forum for describing the issue.