The Wayback Machine - https://web.archive.org/web/20220524113350/https://github.com/zulip/zulip/issues/21863
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make "Remove" button in stream creation UI not red #21863

Open
alya opened this issue Apr 20, 2022 · 11 comments · May be fixed by #21868
Open

Make "Remove" button in stream creation UI not red #21863

alya opened this issue Apr 20, 2022 · 11 comments · May be fixed by #21868

Comments

@alya
Copy link
Collaborator

@alya alya commented Apr 20, 2022

In the "Subscribers" part of the stream creation UI, the "Remove" button for modifying the list of users to add to the stream is red:

Screen Shot 2022-04-20 at 11 00 32 AM

We should make it regular text color instead (similar to the "Cancel" button), as the user is still creating the stream, and not taking a more "serious" action of modifying/deleting something from an existing object.

CZO thread

@zulipbot
Copy link
Member

@zulipbot zulipbot commented Apr 20, 2022

Hello @zulip/server-streams members, this issue was labeled with the "area: stream settings" label, so you may want to check it out!

@medhatiwari
Copy link
Collaborator

@medhatiwari medhatiwari commented Apr 20, 2022

@zulipbot claim

medhatiwari added a commit to medhatiwari/zulip that referenced this issue Apr 20, 2022
zulip#21863 Make Remove button in stream creation UI not red
@medhatiwari medhatiwari removed their assignment Apr 22, 2022
@iamcynthiamamah
Copy link
Collaborator

@iamcynthiamamah iamcynthiamamah commented Apr 22, 2022

@zulipbot claim

@zulipbot
Copy link
Member

@zulipbot zulipbot commented Apr 22, 2022

Hello @iamcynthiamamah, it looks like you've currently claimed 1 issue in this repository. We encourage new contributors to focus their efforts on at most 1 issue at a time, so please complete your work on your other claimed issues before trying to claim this issue again.

We look forward to your valuable contributions!

@IvanToy
Copy link
Collaborator

@IvanToy IvanToy commented Apr 24, 2022

@zulipbot claim

@zulipbot
Copy link
Member

@zulipbot zulipbot commented Apr 24, 2022

Welcome to Zulip, @IvanToy! We just sent you an invite to collaborate on this repository at https://github.com/zulip/zulip/invitations. Please accept this invite in order to claim this issue and begin a fun, rewarding experience contributing to Zulip!

Here's some tips to get you off to a good start:

As you work on this issue, you'll also want to refer to the Zulip code contribution guide, as well as the rest of the developer documentation on that site.

See you on the other side (that is, the pull request side)!

medhatiwari added a commit to medhatiwari/zulip that referenced this issue Apr 25, 2022
Fix: Make Remove button in stream creation UI not red
@IvanToy IvanToy removed their assignment May 3, 2022
@tanyasingh7
Copy link
Collaborator

@tanyasingh7 tanyasingh7 commented May 3, 2022

@zulipbot claim

@eleftheriakaminari
Copy link

@eleftheriakaminari eleftheriakaminari commented May 4, 2022

Hello, can I contribute to this issue?

@zulipbot
Copy link
Member

@zulipbot zulipbot commented May 14, 2022

@tanyasingh7 You have been unassigned from this issue because you have not made any updates for over 14 days. Please feel free to reclaim the issue if you decide to pick up again. Thanks!

@harshit-agarwar
Copy link
Collaborator

@harshit-agarwar harshit-agarwar commented May 21, 2022

@zulipbot claim

@zulipbot
Copy link
Member

@zulipbot zulipbot commented May 21, 2022

Welcome to Zulip, @harshit-agarwar! We just sent you an invite to collaborate on this repository at https://github.com/zulip/zulip/invitations. Please accept this invite in order to claim this issue and begin a fun, rewarding experience contributing to Zulip!

Here's some tips to get you off to a good start:

As you work on this issue, you'll also want to refer to the Zulip code contribution guide, as well as the rest of the developer documentation on that site.

See you on the other side (that is, the pull request side)!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment