The Wayback Machine - https://web.archive.org/web/20220709100345/https://github.com/Rigellute/spotify-tui/issues/490
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change current song progress color #490

Open
tysaya123 opened this issue Jun 6, 2020 · 5 comments
Open

Change current song progress color #490

tysaya123 opened this issue Jun 6, 2020 · 5 comments
Labels
good first issue

Comments

@tysaya123
Copy link

@tysaya123 tysaya123 commented Jun 6, 2020

It would be neat if you could change the color of the text that shows when the progress bar covers it without changing the background. My motivation is that I enjoy the black background but the default color can be hard to read on dark progress bar colors.

Screen Shot 2020-06-06 at 11 50 41 AM

@macguirerintoul
Copy link
Contributor

@macguirerintoul macguirerintoul commented Jun 6, 2020

On a similar note, the bounding box for the text seems to invert the background. It would be nice if only the text would change colour rather than the background as well.

Before passing:
image

After passing:
image

@tysaya123
Copy link
Author

@tysaya123 tysaya123 commented Jun 7, 2020

How were you able to change just the color of the bounding box?

@macguirerintoul
Copy link
Contributor

@macguirerintoul macguirerintoul commented Jun 7, 2020

I wasn't able to, I think it just uses playbar_background and playbar_progress depending on whether it's passed or not

@Rigellute
Copy link
Owner

@Rigellute Rigellute commented Jun 29, 2020

The should be doable! We just need to add another item to the theme config and use that color in the playbar progress

@Rigellute Rigellute added the good first issue label Jun 29, 2020
@Peterkmoss
Copy link
Contributor

@Peterkmoss Peterkmoss commented Aug 25, 2020

As of right now tui doesn't support multiple font colors for widgets / elements, so this would require a rework of how the playbar progress is presented.

update: it seems that if you bump the version of tui to 0.10.0 instead of 0.9.5 there's a method called gauge_style, but there are lots of errors due to thing being depricated. I'm looking into updating this.

@macguirerintoul I can't seem to reproduce that behavior, but I think that's an issue for itself and not this one specifically.

Rigellute added a commit that referenced this issue Sep 1, 2020
…on (#564)

* Bump to tui v. 0.10.0, one line needs fixing

* Compiles with tui 0.10.0, ui needs work

* home layout fixed, playbar needs work

* playbar layout now back to normal and label is using playbar_progress_text

* Formatting

* Fix audio analysis after tui upgrade

Co-authored-by: Alexander Keliris <rigellute@gmail.com>
lanej pushed a commit to lanej/spotify-tui that referenced this issue Jul 13, 2021
…text option (Rigellute#564)

* Bump to tui v. 0.10.0, one line needs fixing

* Compiles with tui 0.10.0, ui needs work

* home layout fixed, playbar needs work

* playbar layout now back to normal and label is using playbar_progress_text

* Formatting

* Fix audio analysis after tui upgrade

Co-authored-by: Alexander Keliris <rigellute@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue
4 participants