The Wayback Machine - https://web.archive.org/web/20220415183614/https://github.com/encode/starlette/issues/1588
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Send 400 on missing boundary #1588

Open
Kludex opened this issue Apr 15, 2022 · 0 comments
Open

Send 400 on missing boundary #1588

Kludex opened this issue Apr 15, 2022 · 0 comments
Labels
clean up good first issue help wanted

Comments

@Kludex
Copy link
Sponsor Member

@Kludex Kludex commented Apr 15, 2022

I did some research about this PR, and to understand if the issue was reasonable.

Here's what I've found out:

On Starlette, we raise KeyError with "boundary key missing". Although this PR follows the issue that was raised, and it's actually an improvement, I think we should follow Django's lead, and also create a 400 response on this case.

Originally posted by @Kludex in #1544 (comment)

@Kludex Kludex added help wanted good first issue clean up labels Apr 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
clean up good first issue help wanted
1 participant