The Wayback Machine - https://web.archive.org/web/20220518182519/https://github.com/glidejs/glide/issues/589
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Setting activeNav class doesn't override default value #589

Open
TijsTT opened this issue Dec 2, 2021 · 2 comments
Open

Setting activeNav class doesn't override default value #589

TijsTT opened this issue Dec 2, 2021 · 2 comments

Comments

@TijsTT
Copy link

@TijsTT TijsTT commented Dec 2, 2021

After the recent updates, setting the activeNav class doesn't override the default glide__bullet--active value anymore. Reverting back to v3.4 solved the issue.

Implemented this using this section in de docs: https://glidejs.com/docs/options/#classes

Anyone else having the same issue?
@chrismheath
Copy link

@chrismheath chrismheath commented Dec 8, 2021

Also having the same issue, reverting back to 3.4 also fixed it for me. I've got a few custom classes on and it was the only one of them which wasn't overriding the default class
@wongjn
Copy link

@wongjn wongjn commented Jan 14, 2022 •
edited

Also ran into this issue. I looked at the source code and the actual options key for the active navigation class is nav.active as per

glide/src/components/controls.js

Line 97 in 3675127

item.classList.add(settings.classes.nav.active)

so:

new Glide('.slider', {
  classes: {
    nav: {
      active: 'custom-active-class',
    },
  },
});

There is a merged PR for updated class options here: glidejs/docs#10 but not on the live site as of time of writing.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
3 participants
@chrismheath @wongjn @TijsTT