The Wayback Machine - https://web.archive.org/web/20220611001007/https://github.com/CodeEditApp/CodeEdit/pull/590
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable tab's context menu option when unavailable. #590

Merged
merged 1 commit into from May 4, 2022

Conversation

lilingxi01
Copy link
Collaborator

@lilingxi01 lilingxi01 commented May 3, 2022

Description

  • When focused tab is the trailing one, "close tabs to the right" option in context menu should be disabled.

Related Issue

  • #572
    (Consideration 3)

Checklist

  • I read and understood the contributing guide as well as the code of conduct
  • My changes generate no new warnings
  • My code builds and runs on my machine
  • I documented my code
  • Review requested

Screenshots

CleanShot.2022-05-03.at.13.20.44.mp4
wdg
wdg approved these changes May 3, 2022
@lilingxi01
Copy link
Collaborator Author

@lilingxi01 lilingxi01 commented May 3, 2022

@austincondiff : I think when we are building editor-splitting behavior, we are going to assign each split a WorkspaceDocument. This "disabled" only affect on the trailing tab of current WorkspaceDocument and it should also apply to every existing WorkspaceDocument when we have multiple (under splitting). So it should be fine.

pkasila
pkasila approved these changes May 4, 2022
@pkasila pkasila merged commit 801744d into CodeEditApp:main May 4, 2022
3 checks passed
@lilingxi01 lilingxi01 deleted the tab-bar-context-fix branch May 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
5 participants