The Wayback Machine - https://web.archive.org/web/20220608020332/https://github.com/playcanvas/engine/pull/4095
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

More TypeScript declarations improvements #4095

Merged
merged 13 commits into from Mar 10, 2022
Merged

More TypeScript declarations improvements #4095

merged 13 commits into from Mar 10, 2022

Conversation

willeastcott
Copy link
Contributor

@willeastcott willeastcott commented Mar 9, 2022 •
edited

  • Correctly types Layer and LayerComposition.
  • Fix SpriteComponent#addClip.
  • Improve ContainerHandler types.
  • Export all callback types.
  • Fix a Vec4 typing issue in the codebase.
  • Remove a couple of redundant typedef comments.
  • Fix ResourceLoaderCallback type definition.
  • Fix DeviceCache#_cache type.

I confirm I have read the contributing guidelines and signed the Contributor License Agreement.
@willeastcott willeastcott added bug docs labels Mar 9, 2022
@willeastcott willeastcott requested a review from mvaligursky Mar 9, 2022
@willeastcott willeastcott self-assigned this Mar 9, 2022
mvaligursky
mvaligursky reviewed Mar 9, 2022
View changes
src/scene/layer.js Show resolved Hide resolved
@mvaligursky mvaligursky self-requested a review Mar 9, 2022
@willeastcott willeastcott merged commit 5b9ff6a into dev Mar 10, 2022
6 checks passed
@willeastcott willeastcott deleted the dts-improvements branch Mar 10, 2022
jpauloruschel pushed a commit that referenced this issue Mar 10, 2022
@willeastcott @jpauloruschel
More TypeScript declarations improvements (#4095)
326f3d3 
* More TypeScript declarations improvements

* Lint fixes

* Remove import

* Finish typing Layer

* Improve CollisionComponent types

* Mark many CollisionComponent functions as private

* Lint fixes

* Add reference to RenderComponent#layers

* Fix Map type in JSDocs

* Export all callbacks

* Improve types for ContainerHandler

* Remove a couple of unused typedefs and fix vector type

* Fix ResourceLoaderCallback type
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug docs
2 participants
@willeastcott @mvaligursky