graph-analysis

Discussed in networkx/networkx#5446

Description

Currently our unit tests are disorganized and each test creates example StellarGraph graphs in different or similar ways with no sharing of this code.

This issue is to improve the unit tests by making functions to create example graphs available to all unit tests by, for example, making them pytest fixtures at the top level of the tests (see https://docs.pytest.org/en/latest/

CASE doesn't work well with null. This works as expected and prints 'works':

WITH 2 AS name
RETURN CASE name
    WHEN 2 THEN 'works'
    WHEN null THEN "doesn't work"
    ELSE 'something went wrong'
END

If we swap the first case from 2 to 3. It should print 'something went wrong', but instead it prints "doesn't work":

WITH 2 AS name
RETURN CASE name
    WHEN 3 THEN 'works'

There is a proof-of-concept github action using https://github.com/ReactiveCircus/android-emulator-runner in branch https://github.com/BrightID/BrightID/tree/automate_detox
It kind of runs, but not usable/reliable.

Things to try:

• Make detox test a release build of the app so we don't need to have metro running in parallel
• Use iOS simulator instead of android emulator
• Fork the android

Following the "const whenever is possible" principle, I would suggest to add this restriction to our code in places where we want our structures not to change and force them to stay untouchable.

Already commented in @ZigRazor PR

As we write and update more docstrings, I think it would be helpful to specify what is expected and to do some checks in CI (and git pre-commit).

Like other libraries in the PyData ecosystem, I think we should rely heavily on the NumPy-style docstrings:

• https://numpydoc.readthedocs.io/en/latest/format.html

We can even use velin to help enforce this and identify common mistakes:

• htt