The Wayback Machine - https://web.archive.org/web/20220706151313/https://github.com/salesagility/SuiteCRM/issues/6914
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sugar PRO references should be removed #6914

Open
horus68 opened this issue Feb 7, 2019 · 4 comments
Open

Sugar PRO references should be removed #6914

horus68 opened this issue Feb 7, 2019 · 4 comments
Labels
Good First Issue Priority:Moderate Type:Bug

Comments

@horus68
Copy link
Contributor

@horus68 horus68 commented Feb 7, 2019 •
edited

Issue

16 files has some sort of Sugar Pro references in code as comments.
Those should be removed

Steps to Reproduce

Try the search with BEGIN: pro
https://github.com/salesagility/SuiteCRM/search?q=BEGIN%3A+pro&type=Code

flav=pro
https://github.com/salesagility/SuiteCRM/search?q=flav%3Dpro&unscoped_q=flav%3Dpro&type=Code

"BEGIN: open_source"
https://github.com/salesagility/SuiteCRM/search?q=%22BEGIN%3A+open_source%22&unscoped_q=%22BEGIN%3A+open_source%22&type=Code

Context

Removing references to former software in code

Related: #5680
@cameronblaikie cameronblaikie added the Type:Suggestion label Feb 8, 2019
@Dillon-Brown Dillon-Brown added Type:Bug Priority:Moderate and removed Type:Suggestion labels Feb 8, 2019
@horus68 horus68 changed the title BEGIN: pro should be removed Sugar references should be removed Jul 22, 2019
@horus68 horus68 changed the title Sugar references should be removed Sugar PRO references should be removed Jul 22, 2019
@Dillon-Brown Dillon-Brown added the Good First Issue label Aug 2, 2019
@asha15
Copy link

@asha15 asha15 commented Oct 6, 2019

@horus68 Shall i work on this?
@pgorod
Copy link
Contributor

@pgorod pgorod commented Oct 6, 2019

@asha15 go ahead, you're welcome!
@asha15
Copy link

@asha15 asha15 commented Oct 11, 2019

@horus68 @pgorod do i need to remove the commend and stripFlavorTags function from this file ?

Screenshot from 2019-10-11 15-35-55
@pgorod
Copy link
Contributor

@pgorod pgorod commented Oct 11, 2019

I guess the answer is yes... Please pay attention to the locations where it is called: https://github.com/salesagility/SuiteCRM/search?utf8=%E2%9C%93&q=stripFlavorTags+&type=
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Good First Issue Priority:Moderate Type:Bug
6 participants
@horus68 @samus-aran @pgorod @Dillon-Brown @asha15 @cameronblaikie