The Wayback Machine - https://web.archive.org/web/20220512004532/https://github.com/LeagueSandbox/GameServer/pull/1447
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introducing IconInfo and a few fixes #1447

Merged
merged 9 commits into from May 9, 2022
Merged

Conversation

cabeca1143
Copy link
Contributor

@cabeca1143 cabeca1143 commented May 8, 2022

  • Introduced IconInfo

  • AttackableUnit

    • Moved CharData down from ObjAiBase.
    • Introduced IconInfo.
    • Introduced override functions to OnSpawn and OnEnterVision in order to properly handle changes to minimap icons
  • GameObject

    • Introduced TeamsWithVision, which returns all teams that have vision of that unit. This is used to assign all teams that had vision of that unit when it had it's icon updated, in order to prevent repetitive calls every time the unit went in and out of vision.
  • Events

    • Fixed an issue where manually removing a triggered listener that has singleInstance = true would cause a crash or remove the wrong listener.
  • Spells

    • Fixed spells with 1 MaxAmmo not getting casted due to CurrentAmmo being 0 after the first cast.
  • The introduction of IconInfo results in the Unit's icons now being properly updated to the clients when changed before the unit's spawn being notified or or when in the FoW to said clients.

@cabeca1143 cabeca1143 changed the title Introducint IconInfo and a few fixes Introducing IconInfo and a few fixes May 8, 2022
Copy link
Contributor

@microsoftv microsoftv left a comment

Good.

@microsoftv microsoftv merged commit 03d2516 into LeagueSandbox:indev May 9, 2022
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants