Introducing IconInfo and a few fixes #1447
Merged
+205
−71
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.


Introduced IconInfo
AttackableUnit
CharDatadown fromObjAiBase.IconInfo.OnSpawnandOnEnterVisionin order to properly handle changes to minimap iconsGameObject
TeamsWithVision, which returns all teams that have vision of that unit. This is used to assign all teams that had vision of that unit when it had it's icon updated, in order to prevent repetitive calls every time the unit went in and out of vision.Events
singleInstance = truewould cause a crash or remove the wrong listener.Spells
MaxAmmonot getting casted due toCurrentAmmobeing 0 after the first cast.The introduction of IconInfo results in the Unit's icons now being properly updated to the clients when changed before the unit's spawn being notified or or when in the FoW to said clients.