The Wayback Machine - https://web.archive.org/web/20220505185549/https://github.com/monicahq/monica/issues/273
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

single entries for food preferences #273

Open
Nebucatnetzer opened this issue Jun 14, 2017 · 4 comments
Open

single entries for food preferences #273

Nebucatnetzer opened this issue Jun 14, 2017 · 4 comments

Comments

@Nebucatnetzer
Copy link

@Nebucatnetzer Nebucatnetzer commented Jun 14, 2017

#62 #76
at the moment food preferences are just a text field which makes it a bit hard to format.
It would probably make sense to collect this as single items.

@bendauphinee
Copy link

@bendauphinee bendauphinee commented Nov 28, 2018

Or even tags might make sense here, instead of even single items. That way, if you were planning a party, you could set a guest list and pull the common tags for the people coming (hypothetical scenario / feature).

@jcassee
Copy link

@jcassee jcassee commented May 24, 2021

I'm looking at an interesting first issue to try and fix. Is the idea to have the Food section work like the Pets or Contact info sections (but probably without a type field)?

@bendauphinee
Copy link

@bendauphinee bendauphinee commented May 24, 2021

That seems like a reasonable idea!

@jcassee
Copy link

@jcassee jcassee commented May 26, 2021

Alright, my idea: food preferences is a separate table, á la pets. A preference is combination of a type (with icon) and a text line. Preference type are:

  • 👍 like
  • 👎 dislike
  • 🚫 allergic

This list can be extended and the preference type can be null.

The change would consist of:

  • Database migration:
    • New database tables food_preferences and food_preference_types.
    • Insert food preference types.
    • Split current contact field food_preferences by newline and insert as food_preference records without type.
    • Remove food_preference field from contact.
  • Change food preferences frontend component to work just like pets.

Suggestions for better naming and other ideas very welcome.

If this sounds good I'll create a PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment