The Wayback Machine - https://web.archive.org/web/20220617133425/https://github.com/Netflix/metaflow/issues/948
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pathspec to create Flow/Run/Step/Task/DataArtifact is not validated #948

Open
romain-intel opened this issue Feb 13, 2022 · 2 comments
Open

Pathspec to create Flow/Run/Step/Task/DataArtifact is not validated #948

romain-intel opened this issue Feb 13, 2022 · 2 comments
Labels
bug good first issue upforgrabs

Comments

@romain-intel
Copy link
Contributor

@romain-intel romain-intel commented Feb 13, 2022

Currently, you can do something like this: Task(Flow/RunID/StepName) and this will not result in an error but then the resulting Task object behaves in a bizarre manner where things like t.data will work but t.data.my_artifact will not for example.

We should validate the format of the pathspec passed in to each object and verify that the following are the only possible cases:

  • Metaflow()
  • Flow('MyFlow')
  • Run('MyFlow/1')
  • Step('MyFlow/1/start')
  • Task('MyFlow/1/start/1')
  • DataArtifact('MyFlow/1/start/1/name')

We should make sure that MyFlow and MyFlow/ behave similarly for example though.

@romain-intel romain-intel added bug good first issue upforgrabs labels Feb 13, 2022
@soma2000-lang
Copy link

@soma2000-lang soma2000-lang commented Feb 19, 2022

Working on this@romain-intel

@romain-intel
Copy link
Contributor Author

@romain-intel romain-intel commented Feb 19, 2022

Awesome! Thanks so much.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug good first issue upforgrabs
2 participants