The Wayback Machine - https://web.archive.org/web/20220128160315/https://github.com/akka/akka/issues/29776
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document what happens when ActorAdapter receives a null #29776

Open
octonato opened this issue Oct 27, 2020 · 4 comments
Open

Document what happens when ActorAdapter receives a null #29776

octonato opened this issue Oct 27, 2020 · 4 comments
Labels
good first issue

Comments

@octonato
Copy link
Member

@octonato octonato commented Oct 27, 2020

ActorAdapter will ignore null message with "Adapter function returned null which is not valid as an .."

However, this seems not be documented. For instance, scaladoc/javadoc of pipeToSelf could mention it as well as any other place where adapters are used.
@raboof
Copy link
Member

@raboof raboof commented Oct 28, 2020

Especially for the scaladsl, we usually consider null to be an invalid value. Wouldn't it be a bit confusing to explicitly document that here but not in other places?
@tulikavijay
Copy link

@tulikavijay tulikavijay commented Sep 30, 2021

Hi @octonato, @raboof I would like to work on this
@johanandren
Copy link
Member

@johanandren johanandren commented Oct 1, 2021

@tulikavijay please go ahead! 👍
@GKuldeepak-Knoldus
Copy link
Contributor

@GKuldeepak-Knoldus GKuldeepak-Knoldus commented Dec 26, 2021

Hi Everyone, Is anyone working on this or should I pick up this issue ?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue
5 participants
@raboof @octonato @johanandren @tulikavijay @GKuldeepak-Knoldus