The Wayback Machine - https://web.archive.org/web/20220614230155/https://github.com/ThreeDotsLabs/watermill/issues/253
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

A comment for the Message.UUID lies #253

Open
xorcare opened this issue Nov 22, 2021 · 1 comment
Open

A comment for the Message.UUID lies #253

xorcare opened this issue Nov 22, 2021 · 1 comment
Labels
good first issue help wanted S

Comments

@xorcare
Copy link

@xorcare xorcare commented Nov 22, 2021

This comment says that the message ID is optional,
but for SQL transport it is a mandatory attribute,
in turn it causes misunderstanding?

Is it possible to fix it or did I get something wrong?

watermill/message/message.go

Line 20 in b9928e7

// It is only used by Watermill for debugging.

watermill/message/message.go

Line 21 in b9928e7

// UUID can be empty.

Place of use
https://github.com/ThreeDotsLabs/watermill-sql/blob/4f39bf82b6180ca2191c791e7cb220fff22b9255/pkg/sql/schema_adapter.go#L48
https://github.com/ThreeDotsLabs/watermill-sql/blob/4f39bf82b6180ca2191c791e7cb220fff22b9255/pkg/sql/schema_adapter_postgresql.go#L33
@roblaszczak
Copy link
Member

@roblaszczak roblaszczak commented Nov 22, 2021

Hey @xorcare, good point! When this comment was written SQL Pub/Sub was not implemented yet. It would be more accurate to put info that usually it's not required, but some Pub/Sub implementation may require this field.

If you have some time feel free to post PR and update doc :)
@roblaszczak roblaszczak added good first issue help wanted S labels Nov 22, 2021
xorcare added a commit to xorcare/watermill that referenced this issue Jun 14, 2022
@xorcare
Update comment for field Message.UUID ThreeDotsLabs#253
9b8bcc8 
This is necessary to inform the developer that in some use cases this
field may be required.
xorcare added a commit to xorcare/watermill that referenced this issue Jun 14, 2022
@xorcare
Update comment for field Message.UUID ThreeDotsLabs#253
320ff1f 
This is necessary to inform the developer that in some use cases this
field may be required.

Signed-off-by: Vasiliy Vasilyuk <xorcare@gmail.com>
xorcare added a commit to xorcare/watermill that referenced this issue Jun 14, 2022
@xorcare
Update comment for field Message.UUID (ThreeDotsLabs#253)
5882178 
This is necessary to inform the developer that in some use cases this
field may be required.

Signed-off-by: Vasiliy Vasilyuk <xorcare@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue help wanted S
2 participants
@roblaszczak @xorcare