The Wayback Machine - https://web.archive.org/web/20220410095548/https://github.com/shuding/nextra/issues/134
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow for changing search input placeholder text (nextra-theme-docs) #134

Open
dami-i opened this issue Apr 19, 2021 · 2 comments
Open

Allow for changing search input placeholder text (nextra-theme-docs) #134

dami-i opened this issue Apr 19, 2021 · 2 comments
Labels
feature request good first issue

Comments

@dami-i
Copy link

@dami-i dami-i commented Apr 19, 2021 •
edited

The title is pretty straight-forward.

I find it would be extremely useful allowing the developer to change the placeholder text of the search input.
This comes very handy when developing apps in languages other than English.

This could be easily defined within a key/value pair inside theme.config.js, maybe something such as:

// ...
  nextLinks: true,
  prevLinks: true,
  search: true,
  searchPlaceholder: 'Search ("/" to focus)', // <<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<
  customSearch: null,
  darkMode: true,
  footer: true,
// ...

Thank you for this awesome template.
@dami-i
Copy link
Author

@dami-i dami-i commented Apr 19, 2021

On second thought, we could be able to define one placeholder for every language.
@shuding shuding added the good first issue label Apr 27, 2021
@Andrewnt219
Copy link

@Andrewnt219 Andrewnt219 commented Oct 5, 2021

Hi @shuding, I'd love to help with the issue, but I can't seem to find where the logic is defined. Can you tell me where to first look at?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request good first issue
3 participants
@shuding @Andrewnt219 @dami-i