The Wayback Machine - https://web.archive.org/web/20220321151140/https://github.com/Automattic/wp-calypso/issues/54022
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Signup: inconsistent width for Domains step #54022

Open
razvanpapadopol opened this issue Jun 25, 2021 · 1 comment
Open

Signup: inconsistent width for Domains step #54022

razvanpapadopol opened this issue Jun 25, 2021 · 1 comment
Labels
Domains Good First Issue [Pri] Normal Signup [Size] S [Type] Bug

Comments

@razvanpapadopol
Copy link
Member

@razvanpapadopol razvanpapadopol commented Jun 25, 2021 •
edited

Steps to reproduce the behavior

Force an invalid state of the /start/domains step in the Signup flow.

What I expected to happen

In all states, width to be as in the default view (960px for the blue signup)

Screenshot 2021-06-25 at 15 56 14

What actually happened

When the step is displayed in an invalid state, 720px width is applied to the step wrapper

Screenshot 2021-06-25 at 15 55 31

Context

Fixing this won't be straightforward since domains__step-section-wrapper class is used in multiple cases, not only for the invalid state. Also, the reskin version should be taken into consideration.
@andrewserong
Copy link
Member

@andrewserong andrewserong commented Jun 28, 2021

I'm not sure if this issue is related, but in the reskinned version of the same step, I noticed that there's a breakpoint where the padding on the step wrapper doesn't appear to be present, so the heading and container goes right up against the left side of the screen (I didn't have time to look closely, apologise for the drive-by report if it's unrelated!):

image
@razvanpapadopol razvanpapadopol mentioned this issue Jun 29, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Domains Good First Issue [Pri] Normal Signup [Size] S [Type] Bug
3 participants
@chriskmnds @razvanpapadopol @andrewserong