The Wayback Machine - https://web.archive.org/web/20220424024736/https://github.com/microsoft/vcpkg/pull/24362
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[asmjit] Update to latest (2022-04-10) #24362

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Copy link
Contributor

@acidicoala acidicoala commented Apr 23, 2022

This PR updates asmjit port to the latest version. It is important because I am working on a new port for asmtk, which depends on the latest asmjit.

Copy link

@github-actions github-actions bot left a comment

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

PRs must add only one version and must not modify any published versions

When making any changes to a library, the version or port-version in vcpkg.json or CONTROL must be modified.

Error: Local changes detected for asmjit but no changes to version or port version.
-- Version: 2022-04-10
-- Old SHA: b193130b484bf5c6e64929ad805e629c82afd24a
-- New SHA: 32f36b855b2e0eed583cc4ea7e53a5157edf441b
-- Did you remember to update the version or port version?
-- Pass `--overwrite-version` to bypass this check.
***No files were updated.***

You have modified or added at least one vcpkg.json where a "license" field is missing.

If you feel able to do so, please consider adding a "license" field to the following files:

  • ports/asmjit/vcpkg.json

Valid values for the license field can be found in the documentation

Copy link

@github-actions github-actions bot left a comment

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

PRs must add only one version and must not modify any published versions

When making any changes to a library, the version or port-version in vcpkg.json or CONTROL must be modified.

Error: Local changes detected for asmjit but no changes to version or port version.
-- Version: 2022-04-10
-- Old SHA: 32f36b855b2e0eed583cc4ea7e53a5157edf441b
-- New SHA: 466750e523bc68eaff511b228dc2230960fd2902
-- Did you remember to update the version or port version?
-- Pass `--overwrite-version` to bypass this check.
***No files were updated.***
@acidicoala
Copy link
Contributor Author

@acidicoala acidicoala commented Apr 23, 2022

It would appear that fbgemm and polyhook2 ports are failing to build now. I'm working on polyhook2 right now, and I can say that the next version will require latest asmjit.

However, I'm not sure what the appropriate course of actions should be for the fbgemm port.

@LilyWangLL LilyWangLL added the category:port-update label Apr 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-update
3 participants