The Wayback Machine - https://web.archive.org/web/20220514015909/https://github.com/microsoft/microsoft-ui-xaml/issues/6357
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TwoPaneView does not revoke events #6357

Open
1 of 2 tasks
MartinZikmund opened this issue Nov 20, 2021 · 1 comment
Open
1 of 2 tasks

TwoPaneView does not revoke events #6357

MartinZikmund opened this issue Nov 20, 2021 · 1 comment
Labels
area-TwoPaneView good first issue help wanted team-Controls wct

Comments

@MartinZikmund
Copy link
Contributor

@MartinZikmund MartinZikmund commented Nov 20, 2021

Describe the bug

The TwoPaneView sets up m_windowSizeChangedRevoker, m_pane1LoadedRevoker and m_pane2LoadedRevoker but it seems they are never revoked. Am I missing something and is it intentional or is it a oversight?

Steps to reproduce the bug

Looking into the code 👀

Expected behavior

No response

Screenshots

No response

NuGet package version

Microsoft.UI.Xaml 2.7.0

Windows app type

  • UWP
  • Win32

Device form factor

Desktop

Windows version

May 2021 Update (19043)

Additional context

No response
@msftbot msftbot bot added the needs-triage label Nov 20, 2021
@StephenLPeters StephenLPeters added area-TwoPaneView team-Controls labels Feb 17, 2022
@StephenLPeters
Copy link
Contributor

@StephenLPeters StephenLPeters commented Feb 17, 2022

@MartinZikmund the revoker object used to establish these event handlers has code in it's destructor to unregister the events. We should probably be revoking these in the OnApplyTemplate call as well, this could cause issues in scenarios where a template is applied to the control multiple times.
@StephenLPeters StephenLPeters added good first issue help wanted and removed needs-triage labels Feb 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-TwoPaneView good first issue help wanted team-Controls wct
3 participants
@MartinZikmund @StephenLPeters @michael-hawker