Fix url_launcher warnings #522
Merged
+18
−15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Dependabot appears to have pulled in a new version of url_launcher, which causes analysis warnings. This fails the master branch as well as PRs, such as #512.
This PR provides a quick fix, using the new non-deprecated methods to launch a URL string. However, I'm not quite sure if these changes will be reflected at the codelab itself once pushed to master, or if something needs to be changed somewhere else? https://codelabs.developers.google.com/codelabs/flutter-github-client/
It may also be good to check the dependabot setup. I'm kinda surprised it was able to merge an updated dependency that caused analysis errors which break master.
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-devrel channel on Discord.