The Wayback Machine - https://web.archive.org/web/20240801091217/https://github.com/web-platform-tests/wpt/pull/33706
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to Python 3.10 compatibility #33706

Merged
merged 5 commits into from
Apr 28, 2022

Conversation

DanielRyanSmith
Copy link
Contributor

Requires updates from #33705 to function.

@DanielRyanSmith
Copy link
Contributor Author

Dependency changes are merged. This change will need to be admin merged due to the "tests failing without changes" failure not taking into account the new code.

@@ -1,2 +1,2 @@
def test_load(session, inline):
def test_load(inline):
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you describe this change in the PR description? Was it necessary to pass CI, and what was going wrong here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe this was a remnant of trying to solve some of the issues I was seeing with the CI. I remember feeling confident that this was a correct change that was not fixed based on how this test is called (the session argument is no longer passed to this function), but I did not document this and it's been long enough that the exact justification for it is slipping my mind. I've removed it and it seems to not affect the CI, so let's just forget about this change for now 🙂

tools/ci/azure/install_python.yml Outdated Show resolved Hide resolved
@DanielRyanSmith
Copy link
Contributor Author

This PR is now updated with the recent Edge changes and should again be ready for submission 🙂

@DanielRyanSmith DanielRyanSmith deleted the py3-10-dep-updates branch May 16, 2022 17:10
foolip added a commit to foolip/wpt that referenced this pull request May 24, 2023
foolip added a commit to foolip/wpt that referenced this pull request May 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment