-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade to Python 3.10 compatibility #33706
Upgrade to Python 3.10 compatibility #33706
Conversation
3929fe3
to
a2ac1d9
Compare
|
Dependency changes are merged. This change will need to be admin merged due to the "tests failing without changes" failure not taking into account the new code. |
| @@ -1,2 +1,2 @@ | |||
| def test_load(session, inline): | |||
| def test_load(inline): | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you describe this change in the PR description? Was it necessary to pass CI, and what was going wrong here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe this was a remnant of trying to solve some of the issues I was seeing with the CI. I remember feeling confident that this was a correct change that was not fixed based on how this test is called (the session argument is no longer passed to this function), but I did not document this and it's been long enough that the exact justification for it is slipping my mind. I've removed it and it seems to not affect the CI, so let's just forget about this change for now 🙂
a2ac1d9
to
d44c847
Compare
removed in web-platform-tests#33755, re-added on rebase
870d6dd
to
39c3c0c
Compare
|
This PR is now updated with the recent Edge changes and should again be ready for submission 🙂 |

Formed in 2009, the Archive Team (not to be confused with the archive.org Archive-It Team) is a rogue archivist collective dedicated to saving copies of rapidly dying or deleted websites for the sake of history and digital heritage. The group is 100% composed of volunteers and interested parties, and has expanded into a large amount of related projects for saving online and digital history.

Requires updates from #33705 to function.