The Wayback Machine - https://web.archive.org/web/20220520163151/https://github.com/microg/GmsCore/issues/1617
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement snapshot feature in maps API #1617

Open
mar-v-in opened this issue Nov 23, 2021 · 4 comments
Open

Implement snapshot feature in maps API #1617

mar-v-in opened this issue Nov 23, 2021 · 4 comments
Labels
enhancement good first issue 🗺 Maps
Milestone
0.2.25

Comments

@mar-v-in
Copy link
Member

@mar-v-in mar-v-in commented Nov 23, 2021

The current implementation of the maps API lacks support for the snapshot() functionality.

https://github.com/microg/GmsCore/blob/master/play-services-maps-core-mapbox/src/main/kotlin/org/microg/gms/maps/mapbox/GoogleMap.kt#L483

This is a requirement for location sharing in Signal messenger.
@mar-v-in mar-v-in added this to the 0.2.23 milestone Nov 23, 2021
@khao-soi
Copy link

@khao-soi khao-soi commented Dec 12, 2021

Is there an easy way to test this function? Last night I tried to implement this method, but I lack experience in kotlin and android development.
@mar-v-in
Copy link
Member Author

@mar-v-in mar-v-in commented Dec 12, 2021

You can try out most maps features (including the snapshot feature) in the maps api demo app: https://github.com/googlemaps/android-samples/releases/tag/v1.6.0
@khao-soi
Copy link

@khao-soi khao-soi commented Dec 13, 2021 •
edited

So, I tried a few things here. When I connect my phone (LOS + microG) and attach the debugger to its com.google.android.gms process it doesn't seem to hit any breakpoint.
When I create a virtual device (Nexus 6 for no specific reason) based on the Android 10.0 microG Image and start the maps demo app I get "Maps SDK for Android Demos (Kotlin) won't run without Google Play Services". Self-Check has everything besides Phonesky and GSF.

Any ideas?
@mar-v-in
Copy link
Member Author

@mar-v-in mar-v-in commented Dec 13, 2021

For using microG in Android Emulator, check https://github.com/microg/GmsCore/wiki/Development-Tools#using-the-emulator

For debugging apps that use Maps API, you need to attach the debugger to the app using Maps, not com.google.android.gms.
@mar-v-in mar-v-in removed this from the 0.2.23 milestone Jan 27, 2022
@mar-v-in mar-v-in added this to the 0.2.24 milestone Jan 27, 2022
@mar-v-in mar-v-in removed this from the 0.2.24 milestone Feb 1, 2022
@mar-v-in mar-v-in added this to the 0.2.25 milestone Feb 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement good first issue 🗺 Maps
2 participants
@mar-v-in @khao-soi