The Wayback Machine - https://web.archive.org/web/20201221143809/https://github.com/h2oai/wave/issues/372
Skip to content

/ wave

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add enter handler for textbox #372

Open
VijithaEkanayake opened this issue Dec 9, 2020 · 2 comments · May be fixed by #407
Open

Add enter handler for textbox #372

VijithaEkanayake opened this issue Dec 9, 2020 · 2 comments · May be fixed by #407
Assignees
@VijithaEkanayake
Labels
feature good first issue ui
Milestone
0.11

Comments

@VijithaEkanayake
Copy link

@VijithaEkanayake VijithaEkanayake commented Dec 9, 2020 •
edited by mturoci

Add enter handler with similar logic onChange has.

Steps to follow:

  1. Setup project for dev.
  2. Find textbox.tsx.
  3. Implement the feature.
  4. Find textbox.py and showcase your new feature there.
  5. Add needed unit tests in textbox.test.tsx.
@VijithaEkanayake VijithaEkanayake self-assigned this Dec 9, 2020
@VijithaEkanayake VijithaEkanayake changed the title Support for adding button next to a text box Support for adding a button next to a text box Dec 9, 2020
@srini-x srini-x modified the milestone: 0.11 Dec 10, 2020
@mturoci mturoci added the ui label Dec 10, 2020
VijithaEkanayake added a commit that referenced this issue Dec 15, 2020
@VijithaEkanayake
Implement searchbar_card for wave
f51ee5a 
searchbar_card can be used to horizontally align textbox and button on the requirement. Fixes: #372
VijithaEkanayake added a commit that referenced this issue Dec 15, 2020
@VijithaEkanayake
Implement searchbar_card for wave
1ec4594 
searchbar_card can be used to horizontally align textbox and button on the requirement. Fixes: #372
@VijithaEkanayake VijithaEkanayake mentioned this issue Dec 15, 2020
Closed
VijithaEkanayake added a commit that referenced this issue Dec 15, 2020
@VijithaEkanayake
Implement searchbar_card for wave
ee3d4d9 
searchbar_card can be used to horizontally align textbox and button on the requirement. Fixes: #372
@lo5
Copy link
Member

@lo5 lo5 commented Dec 17, 2020

The current textbox with a search icon (already supported) can double as a search box if we add enter key handling to it.
@mturoci mturoci changed the title Support for adding a button next to a text box Add enter handler for textbox Dec 17, 2020
@mtanco
Copy link
Contributor

@mtanco mtanco commented Dec 18, 2020

related to #348
@lo5 lo5 added this to the 0.11 milestone Dec 18, 2020
@VijithaEkanayake VijithaEkanayake self-assigned this Dec 18, 2020
VijithaEkanayake added a commit that referenced this issue Dec 18, 2020
@VijithaEkanayake
Add enter handler for textbox
245f308 
Fixes: #372
VijithaEkanayake added a commit that referenced this issue Dec 18, 2020
@VijithaEkanayake
Add enter handler for textbox
5c08d95 
Fixes: #372
@VijithaEkanayake VijithaEkanayake linked a pull request that will close this issue Dec 18, 2020
Open
VijithaEkanayake added a commit that referenced this issue Dec 18, 2020
@VijithaEkanayake
Introduce submit attribute to textbox
be42109 
The implementation conditionally calls the keyup handler based on the values of the submit attribute.
Fixes: #372
VijithaEkanayake added a commit that referenced this issue Dec 18, 2020
@VijithaEkanayake
Introduce submit attribute to textbox
54ea7d5 
The implementation conditionally calls the keyup handler based on the values of the submit attribute.
Fixes: #372
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature good first issue ui
5 participants
@mtanco @VijithaEkanayake @lo5 @srini-x @mturoci
You can’t perform that action at this time.