Support rectangular heightmaps

[Broxzier]

With support for rectangular maps added to the game, the requirement for heightmaps to be square is no longer necessary.

OpenRCT2/src/openrct2/world/MapGen.cpp

Lines 662 to 667 in 5edc561

	auto image = Imaging::ReadFromFile(path, format);
	if (image.Width != image.Height)
	{
	context_show_error(STR_HEIGHT_MAP_ERROR, STR_ERROR_WIDTH_AND_HEIGHT_DO_NOT_MATCH, {});
	return false;
	}

The code below the above check relies on the assumption that the width and height match. This needs to be refactored slightly. Some changes to the related functions might be necessary, though most already threat width and height separately.

OpenRCT2/src/openrct2/world/MapGen.cpp

Line 773 in 5edc561

openrct2_assert(_heightMapData.width == _heightMapData.height, "Invalid height map size");

[ArLough]

Hi, I'm new to contributing and I'd like to take this issue. Is there anything else I should do to take the issue?

[Broxzier]

@ArLough nope, that's all you have to do. For questions you can ask either here or on Discord. Good luck!

[ArLough]

Hi @Broxzier, I was wondering if you would like me to remove the error checking entirely or substitute it with a different error check that takes rectangular maps into consideration? If the latter, what would you like the error checking to look like?

[Broxzier]

Hey @ArLough, the checks are not necessary anymore, so they can be removed entirely.

Edit: Actually, there is a check for map size, but this only checks the width. For rectangular map support, this also needs to check the height, and also clamp them correctly.

OpenRCT2/src/openrct2/world/MapGen.cpp

Lines 669 to 674 in 5edc561

	auto size = image.Width;
	if (image.Width > MAXIMUM_MAP_SIZE_PRACTICAL)
	{
	context_show_error(STR_HEIGHT_MAP_ERROR, STR_ERROR_HEIHGT_MAP_TOO_BIG, {});
	size = std::min<uint32_t>(image.Height, MAXIMUM_MAP_SIZE_PRACTICAL);
	}

[tupaschoal]

For anyone reading, this is up for grabs again. It might be worth looking into the comments of the PR linked above for insight