workspaceId should be part of spec request #12112
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
area/api
timroes
reviewed
Apr 19, 2022
| @@ -28,17 +29,19 @@ function useGetService(): DestinationDefinitionSpecificationService { | |||
|
|
|||
| export const useGetDestinationDefinitionSpecification = (id: string): DestinationDefinitionSpecification => { | |||
| const service = useGetService(); | |||
| const workspaceId = useCurrentWorkspace().workspaceId; | |||
There was a problem hiding this comment.
Suggested change
| const workspaceId = useCurrentWorkspace().workspaceId; | |
| const { workspaceId } = useCurrentWorkspace(); |
timroes
reviewed
Apr 19, 2022
| }; | ||
|
|
||
| export const useGetDestinationDefinitionSpecificationAsync = ( | ||
| id: string | null | ||
| ): QueryObserverResult<DestinationDefinitionSpecification, Error> => { | ||
| const service = useGetService(); | ||
| const workspaceId = useCurrentWorkspace().workspaceId; |
There was a problem hiding this comment.
Suggested change
| const workspaceId = useCurrentWorkspace().workspaceId; | |
| const { workspaceId } = useCurrentWorkspace(); |
timroes
reviewed
Apr 19, 2022
| @@ -28,17 +29,19 @@ function useGetService(): SourceDefinitionSpecificationService { | |||
|
|
|||
| export const useGetSourceDefinitionSpecification = (id: string): SourceDefinitionSpecification => { | |||
| const service = useGetService(); | |||
| const workspaceId = useCurrentWorkspace().workspaceId; | |||
There was a problem hiding this comment.
Suggested change
| const workspaceId = useCurrentWorkspace().workspaceId; | |
| const { workspaceId } = useCurrentWorkspace(); |
timroes
reviewed
Apr 19, 2022
| }; | ||
|
|
||
| export const useGetSourceDefinitionSpecificationAsync = ( | ||
| id: string | null | ||
| ): QueryObserverResult<SourceDefinitionSpecification, Error> => { | ||
| const service = useGetService(); | ||
| const workspaceId = useCurrentWorkspace().workspaceId; |
There was a problem hiding this comment.
Suggested change
| const workspaceId = useCurrentWorkspace().workspaceId; | |
| const { workspaceId } = useCurrentWorkspace(); |
timroes
approved these changes
Apr 19, 2022
FE code looks good to me awaiting some minor code style improvements. Haven't tested locally.
tuliren
approved these changes
Apr 19, 2022
edgao
approved these changes
Apr 20, 2022
alafanechere
approved these changes
Apr 22, 2022
I had to refactor a bit the CLI because it's using the endpoint that was modified in this PR and some signatures in the generated API client changed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Issue : #12139