The Wayback Machine - https://web.archive.org/web/20210706062404/https://github.com/solidjs/solid/issues/430
Skip to content

/ solid

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Storybook support for storybook@latest #430

Open
mnquintana opened this issue Apr 30, 2021 · 4 comments
Open

Update Storybook support for storybook@latest #430

mnquintana opened this issue Apr 30, 2021 · 4 comments
Labels
documentation enhancement good first issue

Comments

@mnquintana
Copy link

@mnquintana mnquintana commented Apr 30, 2021

The Storybook API has changed quite a lot since Solid's Storybook docs were written in 2019. It would be really helpful (and I think go a loooong way toward helping drive adoption, long-term) if Solid could:

  1. Update the docs to reflect the latest Storybook API (hopefully everything still works with 6.2+?)
  2. Abstract all these manual setup steps away with an official Solid framework plugin for Storybook (docs for how to do this here: https://storybook.js.org/docs/react/api/new-frameworks)

Storybook's become a pretty essential piece of the UI development pipeline, and at least for me, official support for it is a prerequisite for seriously considering any frontend frameworks. I miiiight be able to help with setting this up for Solid, although I haven't tried adding support for a new framework to Storybook before. 😅
@rturnq
Copy link

@rturnq rturnq commented Apr 30, 2021

I created storybook-solid a little while ago but haven't had the time to really try it out much. This follows the guide from Storybook you linked. It's not ideal yet as it would need buy-in from Storybook to add it as a community supported framework to they cli tool, but it saves you from having to write boilerplate.

It would be great to get some feedback on this and once it has been tested out a bit more, then maybe we could get it added to the docs.
@ryansolid
Copy link
Member

@ryansolid ryansolid commented Apr 30, 2021

Yeah I'm all for this. I just haven't had the reason to look into it. I was hoping that someone would update the docs at some point. I'm not sure if stuff is different now. If anyone wants to help putting such a plugin together I'd support it and do what is needed to get it recognized. I'm just not working in Storybook personally.
@ryansolid
Copy link
Member

@ryansolid ryansolid commented May 26, 2021

On further review I think we are best setting up a repo for a plugin following the steps and not bothering with docs here. It probably should be managed independently.
@mnquintana
Copy link
Author

@mnquintana mnquintana commented May 27, 2021

Sounds good to me! Let me know if there's anything I can help with.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation enhancement good first issue
4 participants
@mnquintana @ryansolid @rturnq and others