server: implement set_sleep_on_errors() for generic Accept implementations #2567
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tions This adds AcceptWithSleep struct which implements Accept trait and adds a functionality to sleep on errors similar to the AddrIncoming for TcpListener. The reason for this is that this feature is missing for UnixSocket listeners, and other custom listeners implementing Accept.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
This adds AcceptWithSleep struct which implements Accept trait and adds a functionality to sleep on errors similar to the AddrIncoming for TcpListener. The reason for this is that this feature is missing for UnixSocket listeners,
and other custom listeners implementing Accept, but it's not really specific to TcpListener. I'm not sure if/how you would prefer to have this implemented, so opening this PR to get the ball rolling.