Focused crawls are collections of frequently-updated webcrawl data from narrow (as opposed to broad or wide) web crawls, often focused on a single domain or subdomain.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After discussing with the team, we feel the best path forward is a (small) breaking change. Developers will be required to add setupIonicReact to their App.tsx/App.jsx file. This function will call initialize and allow developers to pass in a config, so it can be used instead of setupConfig.
We explored non-breaking change options, but we think this change is the best option long term.
I also noticed that setupConfig was being exported from Angular/React/Vue packages when it should not be. Developers should be going through the main entry points and not calling setupConfig on their own. If they need to eject from the normal process, they should call initialize instead.
Does this introduce a breaking change?
Yes
No
Other information
Migration:
Import setupIonicReact from '@ionic/react';
In App.tsx, call setupIonicReact();. Config should be passed here instead of setupConfig.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.
Pull request checklist
Please check if your PR fulfills the following requirements:
npm run build) was run locally and any changes were pushednpm run lint) has passed locally and any fixes were made for failuresPull request type
Please check the type of change your PR introduces:
What is the current behavior?
Issue Number: resolves #24139
With the Custom Elements build, we now need to call
initialize(): https://github.com/ionic-team/ionic-framework/blob/next/packages/react/src/components/index.ts#L202. The problem is that this call also sets up the Ionic config. Given that Ionic config is not designed to be reactive, subsequent calls tosetupConfighad no effect.What is the new behavior?
setupIonicReactto theirApp.tsx/App.jsxfile. This function will callinitializeand allow developers to pass in a config, so it can be used instead ofsetupConfig.setupConfigon their own. If they need to eject from the normal process, they should callinitializeinstead.Does this introduce a breaking change?
Other information
Migration:
setupIonicReactfrom '@ionic/react';App.tsx, callsetupIonicReact();. Config should be passed here instead ofsetupConfig.setupConfig.