The Wayback Machine - https://web.archive.org/web/20220524191744/https://github.com/SFTtech/openage/issues/1343
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance output summary of converter run for debugging #1343

Open
heinezen opened this issue Dec 18, 2020 · 0 comments
Open

Enhance output summary of converter run for debugging #1343

heinezen opened this issue Dec 18, 2020 · 0 comments
Labels
assets good first issue improvement python
Projects

Comments

@heinezen
Copy link
Member

@heinezen heinezen commented Dec 18, 2020

Required skills: Python

Difficulty: Easy

During a converter run, a bunch of intermediary objects are created in the processor stage, specifically AoE-like and API-like objects. These are used in the transformation from Genie Engine formats to openage formats (e.g. nyan).

The content and helper functions of the intermediary objects are used to map properties of the objects in the original game to properties in the openage API (e.g. a unit's ability). The motivation for having debug output for these objects is that this will help us detect semantic errors in the converter implementation. Because of the high number of objects in the game data, checking this during a live debug is very hard to do.

Debug output of a run contains a plaintext dump of the most relevant content and output of helper functions. We store it in a dedicated directory (assets/converted/debug) and distinguish between the runs by using timestamps for folder names. The debug output is separated by conversion stage (init, read, processor, export). A lot of stuff is already implemented (see here), but improving it can't hurt can it?

Further reading:

@heinezen heinezen added improvement python assets labels Dec 18, 2020
@heinezen heinezen self-assigned this Dec 18, 2020
@heinezen heinezen added good first issue and removed good first issue labels Dec 18, 2020
@heinezen heinezen added this to output in convert Dec 19, 2020
@heinezen heinezen changed the title Output summary of converter run for debugging Enhance output summary of converter run for debugging Dec 31, 2020
@heinezen heinezen assigned heinezen and unassigned heinezen Jan 3, 2021
@heinezen heinezen linked a pull request Jan 19, 2021 that will close this issue
3 tasks
@heinezen heinezen removed a link to a pull request Jan 19, 2021
3 tasks
@heinezen heinezen added the good first issue label Jan 19, 2021
@heinezen heinezen removed their assignment Jan 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
assets good first issue improvement python
1 participant