Describe the bug
When running k9s in a terminal with a light background, and using the transparent k9s-skin, such as Gnome-terminal with the color settings "GNOME light", the text in the header is basically impossible to read, which makes the program unusable.
This also goes for the headers over the big table with contents (whether it's pods, logs, nodes, etc). The column headers are not legible.
The same problem is also present for a lot of error messages, where the text "Boom!!" is printed and then followed up with a description of the error, but this description is also written in a white text, which is unreadable on a light background. This is also the case when running commands like k9s info or k9s version.
The latter issue is slightly better on the default GNOME theme though, because those errors are written in light grey, but light grey against white still has a somewhat questionable contrast ratio.
To Reproduce
Steps to reproduce the behavior:
Download the transparent.yml skin and put it in your $XDG_CONFIG_HOME/k9s/skin.yml
Use a terminal with a light background color
Start k9s
Look at the header, there's white text on a white background, which is unreadable
Expected behavior
I would expect to see the information in the header presented with a text color that is legible against my background. On a light themed terminal, this could for example be my configured "foreground" color instead of a hard-coded "white".
Screenshots
Versions (please complete the following information):
OS: Ubuntu 21.10
K9s: 0.24.15
K8s: client version 1.20.8, server version 1.21.2
Additional context
I believe that using something like the default configured foreground color instead of a hardcoded white (or light grey) color for these fields would significantly improve the usability of k9s for users who prefer to use a light-themed terminal.
The text was updated successfully, but these errors were encountered:
Hey @Frost! 👋
Curious to hear from you if the change made in the merged PR sufficiently addresses the issue from your perspective. Happy to look into other changes if needed. Also - thanks so much for including the very helpful and thorough description of the issue!
Hey @Frost! wave Curious to hear from you if the change made in the merged PR sufficiently addresses the issue from your perspective. Happy to look into other changes if needed. Also - thanks so much for including the very helpful and thorough description of the issue!
Thank you for pinging me about this. That PR (#1837) seems to address my previous issues with the text color. Thank you for that! :)
Frost commentedOct 26, 2021
Describe the bug
When running
k9sin a terminal with a light background, and using thetransparentk9s-skin, such as Gnome-terminal with the color settings "GNOME light", the text in the header is basically impossible to read, which makes the program unusable.This also goes for the headers over the big table with contents (whether it's pods, logs, nodes, etc). The column headers are not legible.
The same problem is also present for a lot of error messages, where the text "Boom!!" is printed and then followed up with a description of the error, but this description is also written in a white text, which is unreadable on a light background. This is also the case when running commands like
k9s infoork9s version.The latter issue is slightly better on the default GNOME theme though, because those errors are written in light grey, but light grey against white still has a somewhat questionable contrast ratio.
To Reproduce
Steps to reproduce the behavior:
$XDG_CONFIG_HOME/k9s/skin.ymlk9sExpected behavior
I would expect to see the information in the header presented with a text color that is legible against my background. On a light themed terminal, this could for example be my configured "foreground" color instead of a hard-coded "white".
Screenshots
Versions (please complete the following information):
Additional context
I believe that using something like the default configured foreground color instead of a hardcoded white (or light grey) color for these fields would significantly improve the usability of
k9sfor users who prefer to use a light-themed terminal.The text was updated successfully, but these errors were encountered: