The Wayback Machine - https://web.archive.org/web/20221221093714/https://github.com/derailed/k9s/issues/1290
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Text in header unreadable with "transparent" skin and light background terminal #1290

Closed
Frost opened this issue Oct 26, 2021 · 3 comments
Closed
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@Frost
Copy link

Frost commented Oct 26, 2021




Describe the bug
When running k9s in a terminal with a light background, and using the transparent k9s-skin, such as Gnome-terminal with the color settings "GNOME light", the text in the header is basically impossible to read, which makes the program unusable.

This also goes for the headers over the big table with contents (whether it's pods, logs, nodes, etc). The column headers are not legible.

The same problem is also present for a lot of error messages, where the text "Boom!!" is printed and then followed up with a description of the error, but this description is also written in a white text, which is unreadable on a light background. This is also the case when running commands like k9s info or k9s version.

The latter issue is slightly better on the default GNOME theme though, because those errors are written in light grey, but light grey against white still has a somewhat questionable contrast ratio.

To Reproduce
Steps to reproduce the behavior:

  1. Download the transparent.yml skin and put it in your $XDG_CONFIG_HOME/k9s/skin.yml
  2. Use a terminal with a light background color
  3. Start k9s
  4. Look at the header, there's white text on a white background, which is unreadable

Expected behavior
I would expect to see the information in the header presented with a text color that is legible against my background. On a light themed terminal, this could for example be my configured "foreground" color instead of a hard-coded "white".

Screenshots

Screenshot from 2021-10-26 14-47-46

Screenshot from 2021-10-26 15-00-31
Screenshot from 2021-10-26 15-00-44

Versions (please complete the following information):

  • OS: Ubuntu 21.10
  • K9s: 0.24.15
  • K8s: client version 1.20.8, server version 1.21.2

Additional context
I believe that using something like the default configured foreground color instead of a hardcoded white (or light grey) color for these fields would significantly improve the usability of k9s for users who prefer to use a light-themed terminal.

@derailed derailed added bug Something isn't working enhancement New feature or request good first issue Good for newcomers and removed bug Something isn't working labels Nov 17, 2021
derailed pushed a commit that referenced this issue Dec 3, 2022
* fix(skins): use additional default colors for 'transparent' skin

* fix(cmd): use default terminal color for cmd output
@wkyoshida
Copy link
Contributor

wkyoshida commented Dec 3, 2022

Hey @Frost! 👋
Curious to hear from you if the change made in the merged PR sufficiently addresses the issue from your perspective. Happy to look into other changes if needed. Also - thanks so much for including the very helpful and thorough description of the issue!

@Frost
Copy link
Author

Frost commented Dec 3, 2022

Hey @Frost! wave Curious to hear from you if the change made in the merged PR sufficiently addresses the issue from your perspective. Happy to look into other changes if needed. Also - thanks so much for including the very helpful and thorough description of the issue!

Thank you for pinging me about this. That PR (#1837) seems to address my previous issues with the text color. Thank you for that! :)

@Frost Frost closed this as completed Dec 3, 2022
@wkyoshida
Copy link
Contributor

wkyoshida commented Dec 3, 2022

Nice - glad to hear!
Cheers

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
3 participants