The Wayback Machine - https://web.archive.org/web/20220706190828/https://github.com/FormidableLabs/spectacle/issues/1014
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chore: Audit prod dependencies #1014

Open
1 task
ryan-roemer opened this issue Apr 28, 2021 · 3 comments
Open
1 task

Chore: Audit prod dependencies #1014

ryan-roemer opened this issue Apr 28, 2021 · 3 comments
Labels
Chore 🤖 Dependencies Good First Issue

Comments

@ryan-roemer
Copy link
Member

@ryan-roemer ryan-roemer commented Apr 28, 2021

We should audit all our prod deps for actual usage. Discovered today that we're not using:
@ryan-roemer ryan-roemer added Chore Good First Issue 🤖 Dependencies labels Apr 28, 2021
@sneakers-the-rat
Copy link

@sneakers-the-rat sneakers-the-rat commented May 4, 2021 •
edited

depcheck (which is not 100% accurate but is a starting point) says:

Unused dependencies
* broadcastchannel-polyfill
* dedent
* marksy
* normalize-newline
* prism-react-renderer

Unused devDependencies
* babel-eslint
* babel-plugin-transform-jsx-to-htm
* typescript
* webpack-cli
@ryan-roemer
Copy link
Member Author

@ryan-roemer ryan-roemer commented May 4, 2021 •
edited

Thanks @sneakers-the-rat

Some random notes:

  • prism-react-render should be removed (it's separately declared and used in docs
  • babel-plugin-transform-jsx-to-htm:

    spectacle/scripts/one-page.js

    Line 36 in 75052e6

    plugins: ['babel-plugin-transform-jsx-to-htm']
  • webpack-cli provides webpack CLI script
  • I think babel-eslint is needed for eslint commands
@todortotev
Copy link

@todortotev todortotev commented May 5, 2021

@ryan-roemer mind if I try helping?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Chore 🤖 Dependencies Good First Issue
3 participants
@ryan-roemer @sneakers-the-rat @todortotev