The Wayback Machine - https://web.archive.org/web/20220128041504/https://github.com/apostrophecms/apostrophe/issues/1381
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

When deleting media, widgets that use that media do not know they are now empty #1381

Open
stuartromanek opened this issue May 16, 2018 · 7 comments
Open

When deleting media, widgets that use that media do not know they are now empty #1381

stuartromanek opened this issue May 16, 2018 · 7 comments
Labels
bug good first issue

Comments

@stuartromanek
Copy link
Member

@stuartromanek stuartromanek commented May 16, 2018

This creates broken UI when there both no placeholder and no image. Perhaps some kind of 'this was recently deleted' message when revisiting the affected field?
@geoffdimasi
Copy link
Contributor

@geoffdimasi geoffdimasi commented May 16, 2018

image
@stuartromanek
Copy link
Member Author

@stuartromanek stuartromanek commented May 16, 2018

similar to #847
@boutell
Copy link
Member

@boutell boutell commented May 22, 2018

@stuartromanek
Copy link
Member Author

@stuartromanek stuartromanek commented May 22, 2018

Hm .. like if you had a slideshow of many images and then you delete one out of the media library, the rest would soldier on and that would be good, right?

A simple enhancement would be to give our house apostrophe-images-widgets template a better placeholder / not found state
@boutell
Copy link
Member

@boutell boutell commented Mar 22, 2019

This is a good first issue. Hint: don't try to implement "this was recently deleted," that is quite difficult. Instead, just edit lib/modules/apostrophe-images-widgets/views/widgetBase.html to ensure that if there are zero images, a helpful hint that you may need to select images appears, but only when the widget can be edited by the user (that is, if data.widget._edit). You're working on a Nunjucks template, so be sure to learn about those first.
@stale
Copy link

@stale stale bot commented Jun 19, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.
@stale stale bot added the stale label Jun 19, 2020
@abea abea added the bug label Jun 22, 2020
@stale stale bot removed the stale label Jun 22, 2020
@zindarato zindarato mentioned this issue May 8, 2021
Closed
@zindarato
Copy link
Contributor

@zindarato zindarato commented May 8, 2021 •
edited

I have a fix for this pending in PR #3040. Hopefully this issue will be ready to close once that PR is reviewed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug good first issue
5 participants
@boutell @geoffdimasi @abea @stuartromanek @zindarato