The Wayback Machine - https://web.archive.org/web/20220316232102/https://github.com/dotnet/runtime/pull/66741
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use ROS<byte> instead of byte[] where it makes sense on S.S.C.Cose #66741

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Jozkee
Copy link
Member

@Jozkee Jozkee commented Mar 16, 2022

For v1 of the library we shipped with many methods receiving byte[] as argument, this was due to defer of thought of where we should properly use ReadOnlySpan<byte> and ReadOnlyMemory<byte>.
This PR should also be a place for further discussion of Span vs Memory usage in the APIs and their interaction with System,Formats.Cbor APIs.

Contributes to #62600 MVP+1.

@Jozkee Jozkee added this to the 7.0.0 milestone Mar 16, 2022
@Jozkee Jozkee requested a review from bartonjs Mar 16, 2022
@Jozkee Jozkee self-assigned this Mar 16, 2022
@dotnet-issue-labeler
Copy link

@dotnet-issue-labeler dotnet-issue-labeler bot commented Mar 16, 2022

Note regarding the new-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, to please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

@msftbot
Copy link
Contributor

@msftbot msftbot bot commented Mar 16, 2022

Tagging subscribers to this area: @dotnet/area-system-security, @vcsjones
See info in area-owners.md if you want to be subscribed.

Issue Details

For v1 of the library we shipped with many methods receiving byte[] as argument, this was due to defer of thought of where we should properly use ReadOnlySpan<byte> and ReadOnlyMemory<byte>.
This PR should also be a place for further discussion of Span vs Memory usage in the APIs and their interaction with System,Formats.Cbor APIs.

Contributes to #62600 MVP+1.

Author: Jozkee
Assignees: Jozkee
Labels:

area-System.Security

Milestone: 7.0.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment