The Wayback Machine - https://web.archive.org/web/20220322163536/https://github.com/Azure/ResourceModules/pull/895
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replaced CuaID implementation (to be discussed) #895

Merged
merged 21 commits into from Mar 10, 2022
Merged

Replaced CuaID implementation (to be discussed) #895

merged 21 commits into from Mar 10, 2022

Conversation

MrMCake
Copy link
Contributor

@MrMCake MrMCake commented Jan 17, 2022 •
edited

Change

  • Replaced CuaID implementation with single-file solution
  • Added repository setting for telemetry GUID
  • Added implementation to optionally pass ID to template via pipeline (both GH & ADO)

Pipeline reference

Platform Pipeline
GitHub AnalysisServices: Servers
Azure DevOps IaCS

Type of Change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update (Wiki)
@MrMCake MrMCake self-assigned this Jan 17, 2022
@MrMCake MrMCake marked this pull request as draft Jan 17, 2022
@MrMCake MrMCake linked an issue that may be closed by this pull request Jan 17, 2022
Update CuaID implementation #882
Closed
@github-actions
Copy link

@github-actions github-actions bot commented Jan 17, 2022 •
edited

Unit Test Results

  1 files  1 suites   19s ⏱️
  4 tests 4 ✔️   0 💤 0 ❌
36 runs  4 ✔️ 32 💤 0 ❌

Results for commit 3e7bda0.

♻️ This comment has been updated with latest results.
@MrMCake MrMCake changed the title Replaced CuaID implementation Replaced CuaID implementation (to be discussed) Jan 17, 2022
@MrMCake MrMCake requested a review from mblant Feb 8, 2022
@MrMCake MrMCake marked this pull request as ready for review Mar 1, 2022
mblant
mblant suggested changes Mar 3, 2022
View changes
Copy link

@mblant mblant left a comment

Can we change enableDefaultTelemetry to true by default?
@MrMCake
Copy link
Contributor Author

@MrMCake MrMCake commented Mar 4, 2022

Can we change enableDefaultTelemetry to true by default?

Hey @mblant, it is actually enabled by default via the settings.json config that is injected into each CI deployment. However, I now set it to true in the templates themselves.

From a consumer perpective, that means, they'd need to actively it in the settings.json when running the CI pipelines, and actively add a parameter to set the telemetry to false when building a solution with the templates.
@MrMCake MrMCake enabled auto-merge (squash) Mar 10, 2022
MariusStorhaug
MariusStorhaug approved these changes Mar 10, 2022
View changes
Copy link
Member

@MariusStorhaug MariusStorhaug left a comment

Lets just get it in.
@MrMCake MrMCake merged commit 9518f36 into main Mar 10, 2022
80 of 88 checks passed
@MrMCake MrMCake deleted the users/alsehr/882_cuaId branch Mar 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[cat] modules help wanted
3 participants
@MrMCake @MariusStorhaug @mblant