The Wayback Machine - https://web.archive.org/web/20230220173950/https://github.com/matteobruni/tsparticles/issues/2276
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improving CONTRIBUTING.md #2276

Closed
matteobruni opened this issue Oct 1, 2021 · 9 comments
Closed

Improving CONTRIBUTING.md #2276

matteobruni opened this issue Oct 1, 2021 · 9 comments
Assignees
@matteobruni @ainneo @nishihere19 @utkarshhbtu
Labels
documentation Improvements or additions to documentation good first issue Good for newcomers Hacktoberfest help wanted Extra attention is needed pinned Pinned issues triage up-for-grabs
Projects
High Priority

Comments

@matteobruni
Copy link
Owner

matteobruni commented Oct 1, 2021 •
edited

The CONTRIBUTING.md is outdated and needs some updates, for example it's not mentioned anything about building or running the project.

For building the first time:

Unix

yarn && npx lerna bootstrap && npx lerna run build

Windows

yarn
npx lerna bootstrap
npx lerna run build

For building local packages it's possible to run only

yarn build

in every folder with a package.json file

For running demos

yarn start

or

yarn serve

where the start commands returns an error (this could be another improvement)
@matteobruni matteobruni self-assigned this Oct 1, 2021
@xscode-auto-reply
Copy link

Thanks for opening a new issue. The team has been notified and will review it as soon as possible.

For urgent issues and priority support, visit https://xscode.com/matteobruni/tsparticles
@matteobruni matteobruni added this to To do in High Priority via automation Oct 1, 2021
@matteobruni matteobruni added documentation Improvements or additions to documentation Hacktoberfest good first issue Good for newcomers help wanted Extra attention is needed pinned Pinned issues up-for-grabs labels Oct 1, 2021
@MidouWebDev MidouWebDev removed their assignment Oct 2, 2021
@nishihere19
Copy link

Can I work on this issue?
@utkarshhbtu
Copy link

can i work on this issue
@ainneo
Copy link

ainneo commented Oct 11, 2021

is this being worked on? I would like to do it.
timscodebase added a commit to timscodebase/tsparticles that referenced this issue Oct 11, 2021
@timscodebase
Improving CONTRIBUTING.md matteobruni#2276
8ec2543
@timscodebase
Copy link
Contributor

I submitted a PR #2333
matteobruni added a commit that referenced this issue Oct 12, 2021
@matteobruni
Merge pull request #2333 from timscodebase/contribute
2890ce9 
Improving CONTRIBUTING.md #2276
@tamoghna-dey
Copy link
Contributor

Is this issue still open?
@matteobruni
Copy link
Owner Author

Is this issue still open?

Yes
@tamoghna-dey
Copy link
Contributor

I am working on the file. I hope I am able to add something valuable
@tamoghna-dey
Copy link
Contributor

I just submitted a PR.
High Priority automation moved this from To do to Done Aug 16, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 20, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Improvements or additions to documentation good first issue Good for newcomers Hacktoberfest help wanted Extra attention is needed pinned Pinned issues triage up-for-grabs
7 participants
@matteobruni @ainneo @nishihere19 @timscodebase @MidouWebDev @utkarshhbtu @tamoghna-dey