The Wayback Machine - https://web.archive.org/web/20220305013305/https://github.com/aws/sagemaker-python-sdk/pull/631
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Treat warnings as errors when building documentation. #631

Merged
merged 5 commits into from Feb 7, 2019

Conversation

nadiaya
Copy link
Contributor

@nadiaya nadiaya commented Feb 7, 2019

Treat warnings as errors when building documentation. Migrate readthedocs configuration to version 2 and switch to use requirements.txt instead of conda environment in order to do so.

Merge Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works (if appropriate)
  • I have updated the changelog with a description of my changes (if appropriate)
  • I have updated any necessary documentation (if appropriate)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@nadiaya nadiaya requested review from ChoiByungWook and iquintero Feb 7, 2019
@nadiaya nadiaya merged commit 69c45ce into master Feb 7, 2019
4 checks passed
@nadiaya nadiaya deleted the warnings-into-errors branch Feb 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants